-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper Saejin #56
base: master
Are you sure you want to change the base?
Paper Saejin #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Saejin, you hit the learning goals here. Well done! There are some tests failing and I left notes on that inline.
setSquares(newSquares) | ||
setCount(count+1) | ||
|
||
if (currentPlayer === PLAYER_1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note the tests are failing because it's expecting lower case letters. You can fix it by changing PLAYER_1 and PLAYER_2 to lower case letters, or adjusting the tests.
|
||
if (!winner) { | ||
checkForWinner() | ||
} | ||
|
||
const resetGame = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
No description provided.