Scissors - Sneha Agarwal #67
Conversation
| //console.log('row_num', rowNum); | ||
| //console.log('col_num', colNum); | ||
| // set the value of the square on square button click | ||
| squares[rowNum][colNum] = {id:id, value:player}; |
There was a problem hiding this comment.
When using React useState hook, we shouldn't directly modify squares. Instead, we can make a copy of squares using the spread operator const newSquares = [...squares]. Then we assign our new value to our newSquares and call setSquares(newSquares). This is because of how the useState hook works. In this code, it ends up working because we also call setPlayer which triggers a re-render.
| if (sqValue.value != e){ | ||
| emptySquareCounts -= 1; | ||
| } | ||
| console.log('empty square counts:', emptySquareCounts); |
There was a problem hiding this comment.
I see that you commented out most of the console.log statements and probably just forgot to comment out this one.
It's generally best to remove console.log statements that were written for debugging purposes before submitting a PR, rather than comment them out, since they will probably serve no useful purpose again now that the program all works properly.
There was a problem hiding this comment.
Sure, Thanks for the feedback Jared!
No description provided.