Paper - Kaylyn Cardella #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 31, 2021
| @@ -0,0 +1,122 @@ | |||
| def create_movie(movie_title, genre, rating): | |||
|
|
||
| return new_movie | ||
|
|
||
| def add_to_watched(user_data, movie): |
| user_data["watched"].append(movie) | ||
| return user_data | ||
|
|
||
| def add_to_watchlist(user_data, movie): |
| user_data["watchlist"].append(movie) | ||
| return user_data | ||
|
|
||
| def watch_movie(user_data, title): |
|
|
||
| return user_data | ||
|
|
||
| def get_watched_avg_rating(user_data): |
| return (max(genres)) | ||
|
|
||
| def get_unique_watched(user_data): | ||
| user_set = {movie["title"] for movie in user_data["watched"]} |
Comment on lines
+72
to
+74
| for friend in user_data["friends"]: | ||
| for movie in friend["watched"]: | ||
| friends_set.add(movie["title"]) |
There was a problem hiding this comment.
This segment seems repeated, could you create or use a helper method?
|
|
||
| return friends_unique_movies | ||
|
|
||
| def get_available_recs(user_data): |
| return recommendations | ||
|
|
||
| def get_new_rec_by_genre(user_data): | ||
| most_popular = get_most_watched_genre(user_data) |
There was a problem hiding this comment.
Good reuse of an existing method
|
|
||
| return recommendations | ||
|
|
||
| def get_rec_from_favorites(user_data): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.