Maple-AndreaY&Elly.-C16 #50
Conversation
| # pass | ||
|
|
||
| # def append_to_list(self, customers_json): | ||
| # return [customer for customer in customers_json] |
| delete-orphan", lazy="joined") | ||
|
|
||
| def to_json(self): |
| # available_inventory = db.Column(db.Integer) |
| @@ -0,0 +1,9 @@ | |||
| # from flask.json import jsonify | |||
There was a problem hiding this comment.
Did you plan on using this file? If not, you can delete it.
| #if num_outstanding_rental_with_customer_id: | ||
| # return {"message" : f"Customer {customer_id} has outstanding rentals"}, 200 |
| customer_dict = { | ||
| "id" : customer.id, | ||
| "name" : customer.name, | ||
| "postal_code" : customer.postal_code, | ||
| "phone": customer.phone, | ||
| "register_at" : customer.register_at | ||
| } |
There was a problem hiding this comment.
you created an instance method in your Customer model to handle this. I would use it here.
| if "name" in err.args: | ||
| return {"details" : f"Request body must include name."}, 400 | ||
| if "postal_code" in err.args: | ||
| return {"details" : f"Request body must include postal_code."}, 400 | ||
| if "phone" in err.args: | ||
| return {"details" : f"Request body must include phone."}, 400 |
There was a problem hiding this comment.
you could create a function to handle these guard clauses dynamically and then use that function for customers and videos it could look something like
def validate_parameters(request_body, parameters):
for attribute in parameters:
if attribute not in request_body:
abort(make_response({"details": f"Request body must include {attribute}."}, 400))
| video_dict = { | ||
| "id" : video.id, | ||
| "title" : video.title, | ||
| "release_date" : video.release_date, | ||
| "total_inventory": video.total_inventory | ||
| } |
There was a problem hiding this comment.
this could be moved to your video model and made an instance method
| num_of_rental = Rental.query.filter_by(video_id = video_id).count() | ||
| available_inventory = video.total_inventory - num_of_rental |
There was a problem hiding this comment.
You could add video_checkout_count as a column in your customer model then you could do something like
customer.videos_checked_out_count += 1
video.available_inventory -= 1
|
Good Job Andrea and Elly! I liked some of the extra functions you all added and the use of try/except clauses. I added some comments on using instance methods you already created and refactoring some of your code. Let me know if you have questions. |
No description provided.