C16MapleFaithKauweSwap-MeetFinal #73
Conversation
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
You can use inheritance here by invoking super()
| self.category = category | |
| self.condition = condition | |
| super().__init__(category="Clothing",condition) |
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
You can use inheritance here by invoking super()
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
You can use inheritance here by invoking super()
| def __str__(self): | ||
| return 'Hello World!' | ||
|
|
||
| def condition_description(self): |
There was a problem hiding this comment.
great way to create a conditional based on ranges here!
| list_by_category.append(item) | ||
| return list_by_category | ||
|
|
||
| def swap_items(self, vendor, my_item, their_item): |
| else: | ||
| return False | ||
|
|
||
| def swap_first_item(self, vendor): |
There was a problem hiding this comment.
You already have a function that will do this work for you! swap_items() can be called here and then you would pass in the first item of the vender and the other vendor as arguments
return self.swap_items(other, self.inventory[0], other.inventory[0])
| if item.condition == max_condition: | ||
| return item | ||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
There was a problem hiding this comment.
great approach using get best by category
| else: | ||
| self.swap_items(other, my_best, their_best) | ||
| return True | ||
| def swap_by_newest(self, other): |
|
Great work Faith! I liked how you approached these functions and used different built-in methods. I added some comments on refactoring and the use of helper functions. |
No description provided.