Nicole W : Maple #91
Open
Nicole W : Maple #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Oct 8, 2021
Comment on lines
+5
to
+6
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
You can use inheritance here by invoking super()
Suggested change
| self.category = category | |
| self.condition = condition | |
| super().__init__(category="Clothing",condition) |
tgoslee
reviewed
Oct 8, 2021
Comment on lines
+6
to
+7
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
You can use inheritance here by invoking super()
tgoslee
reviewed
Oct 8, 2021
Comment on lines
+6
to
+7
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
You can use inheritance here by invoking super()
tgoslee
reviewed
Oct 8, 2021
Comment on lines
+13
to
+26
| condition = self.condition | ||
| if condition >= 0 and condition < 1: | ||
| description = "yikes,raggedy, on its last leg" | ||
| if condition >= 1 and condition < 2: | ||
| description = "eek,heavy use,'rough around the edges'" | ||
| if condition >= 2 and condition < 3: | ||
| description = "eh,well used" | ||
| if condition >= 3 and condition < 4: | ||
| description = "ok,expected wear and tear" | ||
| if condition >= 4 and condition < 5: | ||
| description = "good,light use" | ||
| if condition == 5: | ||
| description = "superb,outstanding,like new" | ||
| return description |
There was a problem hiding this comment.
Using ranges was a great approach and I love the descriptions. Here is a suggestion to use less lines of code
Suggested change
| condition = self.condition | |
| if condition >= 0 and condition < 1: | |
| description = "yikes,raggedy, on its last leg" | |
| if condition >= 1 and condition < 2: | |
| description = "eek,heavy use,'rough around the edges'" | |
| if condition >= 2 and condition < 3: | |
| description = "eh,well used" | |
| if condition >= 3 and condition < 4: | |
| description = "ok,expected wear and tear" | |
| if condition >= 4 and condition < 5: | |
| description = "good,light use" | |
| if condition == 5: | |
| description = "superb,outstanding,like new" | |
| return description | |
| if self.condition > 4.0: | |
| return "Very good condition" | |
| elif 3.0 < self.condition <= 4.0: | |
| return "Pretty good condition" | |
| elif 2.0 < self.condition <= 3.0: | |
| return "Noticeable wear and tear" | |
| else: | |
| return "Fashionably rustic" |
tgoslee
reviewed
Oct 8, 2021
| return False | ||
|
|
||
| #Wave 02 | ||
| def get_by_category(self,category): |
tgoslee
reviewed
Oct 8, 2021
| output: returns True: if items in list and swapped | ||
| else: returns False | ||
| ''' | ||
| if my_item in self.inventory and their_item in other_vendor.inventory: |
tgoslee
reviewed
Oct 8, 2021
| ''' | ||
| if bool(self.inventory) == False or bool(other_vendor.inventory) == False: | ||
| return False | ||
| else: |
There was a problem hiding this comment.
You already have a function that will do this work for you! swap_items() can be called here and then you would pass in the first item of the vender and the other vendor as arguments
return self.swap_items(other, self.inventory[0], other.inventory[0])
tgoslee
reviewed
Oct 8, 2021
| return None | ||
|
|
||
|
|
||
| def swap_best_by_category(self,other = "", my_priority= "",their_priority=""): |
|
Great job Nicole! Your code was clear and readable. I added some comments on refactoring a few functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.