Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ericka & Janice Group Fansite- Sapphire #33

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions agreements.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
Accessibility Needs
What does each team member need access to in order to succeed and show up the best they can?
J: open communication, guess culture
E: time to reread instructions at beginning of work period, guess culture


Collaboration vs. individual work expectations
Clarify your collaboration expectations- does your group want to write code together all of the time? Or divide work to do independently, then come together to share accomplishments? What tools and technologies can help your collaboration?
- switch between driving and navigating, collaboration work


Learning Style
How does each team member learn best in project settings?
J: hands on, read over instructions
E: trading off driving and navigating using VS live code share


Preferred Feedback Style
How does each team member best receive feedback?
J: face to face, nicely
E: give me all the feedback, but kindly


One Team Communication Skill to Improve
What is a teamwork-related skill you want to work on?
J: talk out loud about code, explain code and talk through it
E: celebrate progress


Optional: Other agreements
Other co-working agreements that were not captured in the above sections.
J:
E:


Signatures
Ericka Moreno
Janice Nguyen
7 changes: 7 additions & 0 deletions ideas.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
- Greys anatomy

fun facts:
- longest running show with female showrunner (?)
- etc from google

gallery: pictures of characters with funny quotes
Binary file added images/alex-karav.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/christina-yang.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/cristina_yang.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/derek-shepard.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/derek-shepard1.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/george-omalley.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/greys anatomy.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/greys season 1.webp
Binary file not shown.
Binary file added images/greys_cast.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/izzie-stevens.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/meredith-grey.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/miranda-bailey.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/richard-webber.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 18 additions & 0 deletions pages/facts.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,27 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="/styles/styles.css">
<link rel="stylesheet" href="/styles/facts.css">
<title>Document</title>
</head>
<body>
<nav class="nav">
<h1>Janice and Ericka's Grey's Anatomy Fan Page!</h1>
<h3>Fun Facts!</h3>
<a class="active" href="/pages/index.html">Home</a>
<a href="/pages/facts.html" rel="import">Fun Facts</a>
<a href=/pages/gallery.html rel="import">Gallery</a>
</nav>
<ol>
<li>Most episodes are named after songs</li>
<li>There are 2 spinoff shows made from Grey's Anatomy</li>
<li>Only 3 of the main season 1 cast members are still on the show</li>
</ol>


</body>
<footer>
copyright Janice and Ericka 2023
</footer>
</html>
60 changes: 54 additions & 6 deletions pages/gallery.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,60 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="/styles/styles.css">
<link rel="stylesheet" href="/styles/gallery.css">
<title>Gallery</title>
</head>

<body>

<nav class="nav">
<h1>Janice and Ericka's Grey's Anatomy Fan Page!</h1>
<h3>Gallery</h3>
Comment on lines +15 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For semantic HTML, I'd expect there to be h2 used before h3. If you need it to be h3 in order to have a better font size, you should use h2 still and use CSS to change the text size.

This goes throughout your project

<a class="active" href="/pages/index.html">Home</a>
<a href="/pages/facts.html" rel="import">Fun Facts</a>
<a href=/pages/gallery.html rel="import">Gallery</a>
</nav>
<section class="image-container">
<div class="item1">
<img src="/images/meredith-grey.jpg" alt="Meredith Grey">
<p class="character">Meredith Grey</p>
</div>
<div class="item2">
<img src="/images/cristina_yang.jpg" alt="Cristina Yang">
<p class="character">Christina Yang</p>
</div>
Comment on lines +22 to +29
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering how all these items have identical structure, I would really recommend using that to your advantage.

What if the div had a reused class, like character-item instead of a unique item1 class?

Then, what if instead of class="character" on each paragraph, you could select the paragraph child of any element with the character-item class?

<div class="item3">
<img src="/images/alex-karav.jpg" alt="Alex Karev">
<p class="character">Alex Karev</p>
</div>
<div class="item4">
<img src="/images/george-omalley.jpg" alt="George O'malley">
<p class="character">George O'malley</p>
</div>
<div class="item5">
<img src="/images/izzie-stevens.jpg" alt="Izzy Stevens">
<p class="character">Izzie Stevens</p>
</div>
<div class="item6">
<img src="/images/derek-shepard1.jpg" alt="Derek Shepard">
<p class="character">Derek Shepard</p>
</div>
<div class="item7">
<img src="/images/miranda-bailey.jpg" alt="Miranda Bailey">
<p class="character">Miranda Bailey</p>
</div>
<div class="item8"><img src="/images/richard-webber.jpg" alt="Richard Webber">
<p class="character">Richard Webber</p>
</div>
Comment on lines +22 to +52
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of these different divs has unique classes, item1, item2, ... item8.

  • If they are unique, I would expect these to be IDs, not classes
  • The classes item5 and up aren't used anywhere, so I would expect these to be deleted

</section>
</body>
</html>
<footer>
copyright Janice and Ericka 2023
</footer>

</html>

36 changes: 26 additions & 10 deletions pages/index.html
Original file line number Diff line number Diff line change
@@ -1,12 +1,28 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>

</body>
</html>
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="/styles/styles.css">
<link rel="stylesheet" href="/styles/index.css">
<title>Document</title>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the title

</head>
<body>

<nav class="nav">
<h1>Janice and Ericka's Grey's Anatomy Fan Page!</h1>
<a class="active" href="#home">Home</a>
<a href="/pages/facts.html" rel="import">Fun Facts</a>
<a href=/pages/gallery.html rel="import">Gallery</a>
Comment on lines +16 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does rel="import" do? Should this be here?

</nav>
<img src="/images/greys_cast.jpeg" alt="cast photo">
<p class="main">We are #1 Grey's Anatomy fans!</p>

</body>
<footer>
copyright Janice and Ericka 2023
</footer>
</html>


13 changes: 13 additions & 0 deletions styles/facts.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
.nav {
color: darkslategrey;
text-align: left;
background-color: lightblue;
display: inline-block;
border-style: dotted;
border-color: slateblue;
border-width: medium;
}

h3 {
color: peru;
}
51 changes: 51 additions & 0 deletions styles/gallery.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
body {
background-color: lightblue;
}

p {
font-family: Arial, Helvetica, sans-serif;
font-size: 20px;
color: black
}

.nav {
color: darkslategrey;
text-align: left;
background-color: lightblue;
display: inline-block;
border-style: dotted;
border-color:lightseagreen;
}

img {
width:150px;
height: auto;
}

Comment on lines +1 to +24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throughout the project, there seems to be inconsistent tab-spacing. It'd probably be good to conform to 2 or 4 spaces for tabs.

.character {
color: grey;
}
.image-container {
display: grid;
grid-template-columns: repeat (4, 1fr);
grid-template-rows: repeat (2, 1fr);
grid-column-gap: 16px;
grid-row-gap: 16px;
}

.item1 {
grid-column:1/2;
grid-row: 1/2;
}

.item2 {
grid-column: 2/3;
}

.item3 {
grid-column: 3/4;
}

.item4 {
grid-column: 4/5;
}
7 changes: 7 additions & 0 deletions styles/index.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.main {
color: black;
}

img {
width: 800px;
}
20 changes: 20 additions & 0 deletions styles/styles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
* {
background-color: lightblue;
margin: 10px;
}

.nav {
color: darkslategrey;
text-align: left;
background-color: lightblue;
display: flex;
display: inline-block;
border-style: dotted;
border-color: plum;
}

p {
color: darkolivegreen;
}