-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ericka & Janice Group Fansite- Sapphire #33
base: main
Are you sure you want to change the base?
Changes from all commits
b251b47
d8027f7
2cc3629
2ee4099
1609edd
974412f
38d86e8
51064de
3dec861
8b479a6
69726f2
6a70c6d
752741d
e9278f3
d5e53e7
13c6f86
2c18706
976c3d2
d597d6c
9f841e7
780f540
f461455
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
Accessibility Needs | ||
What does each team member need access to in order to succeed and show up the best they can? | ||
J: open communication, guess culture | ||
E: time to reread instructions at beginning of work period, guess culture | ||
|
||
|
||
Collaboration vs. individual work expectations | ||
Clarify your collaboration expectations- does your group want to write code together all of the time? Or divide work to do independently, then come together to share accomplishments? What tools and technologies can help your collaboration? | ||
- switch between driving and navigating, collaboration work | ||
|
||
|
||
Learning Style | ||
How does each team member learn best in project settings? | ||
J: hands on, read over instructions | ||
E: trading off driving and navigating using VS live code share | ||
|
||
|
||
Preferred Feedback Style | ||
How does each team member best receive feedback? | ||
J: face to face, nicely | ||
E: give me all the feedback, but kindly | ||
|
||
|
||
One Team Communication Skill to Improve | ||
What is a teamwork-related skill you want to work on? | ||
J: talk out loud about code, explain code and talk through it | ||
E: celebrate progress | ||
|
||
|
||
Optional: Other agreements | ||
Other co-working agreements that were not captured in the above sections. | ||
J: | ||
E: | ||
|
||
|
||
Signatures | ||
Ericka Moreno | ||
Janice Nguyen |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
- Greys anatomy | ||
|
||
fun facts: | ||
- longest running show with female showrunner (?) | ||
- etc from google | ||
|
||
gallery: pictures of characters with funny quotes |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,60 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
|
||
<head> | ||
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> | ||
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<link rel="stylesheet" href="/styles/styles.css"> | ||
<link rel="stylesheet" href="/styles/gallery.css"> | ||
<title>Gallery</title> | ||
</head> | ||
|
||
<body> | ||
|
||
<nav class="nav"> | ||
<h1>Janice and Ericka's Grey's Anatomy Fan Page!</h1> | ||
<h3>Gallery</h3> | ||
<a class="active" href="/pages/index.html">Home</a> | ||
<a href="/pages/facts.html" rel="import">Fun Facts</a> | ||
<a href=/pages/gallery.html rel="import">Gallery</a> | ||
</nav> | ||
<section class="image-container"> | ||
<div class="item1"> | ||
<img src="/images/meredith-grey.jpg" alt="Meredith Grey"> | ||
<p class="character">Meredith Grey</p> | ||
</div> | ||
<div class="item2"> | ||
<img src="/images/cristina_yang.jpg" alt="Cristina Yang"> | ||
<p class="character">Christina Yang</p> | ||
</div> | ||
Comment on lines
+22
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Considering how all these items have identical structure, I would really recommend using that to your advantage. What if the div had a reused class, like Then, what if instead of |
||
<div class="item3"> | ||
<img src="/images/alex-karav.jpg" alt="Alex Karev"> | ||
<p class="character">Alex Karev</p> | ||
</div> | ||
<div class="item4"> | ||
<img src="/images/george-omalley.jpg" alt="George O'malley"> | ||
<p class="character">George O'malley</p> | ||
</div> | ||
<div class="item5"> | ||
<img src="/images/izzie-stevens.jpg" alt="Izzy Stevens"> | ||
<p class="character">Izzie Stevens</p> | ||
</div> | ||
<div class="item6"> | ||
<img src="/images/derek-shepard1.jpg" alt="Derek Shepard"> | ||
<p class="character">Derek Shepard</p> | ||
</div> | ||
<div class="item7"> | ||
<img src="/images/miranda-bailey.jpg" alt="Miranda Bailey"> | ||
<p class="character">Miranda Bailey</p> | ||
</div> | ||
<div class="item8"><img src="/images/richard-webber.jpg" alt="Richard Webber"> | ||
<p class="character">Richard Webber</p> | ||
</div> | ||
Comment on lines
+22
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Each of these different divs has unique classes,
|
||
</section> | ||
</body> | ||
</html> | ||
<footer> | ||
copyright Janice and Ericka 2023 | ||
</footer> | ||
|
||
</html> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,28 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>Document</title> | ||
</head> | ||
<body> | ||
|
||
</body> | ||
</html> | ||
<head> | ||
<meta charset="UTF-8"> | ||
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<link rel="stylesheet" href="/styles/styles.css"> | ||
<link rel="stylesheet" href="/styles/index.css"> | ||
<title>Document</title> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to change the title |
||
</head> | ||
<body> | ||
|
||
<nav class="nav"> | ||
<h1>Janice and Ericka's Grey's Anatomy Fan Page!</h1> | ||
<a class="active" href="#home">Home</a> | ||
<a href="/pages/facts.html" rel="import">Fun Facts</a> | ||
<a href=/pages/gallery.html rel="import">Gallery</a> | ||
Comment on lines
+16
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does |
||
</nav> | ||
<img src="/images/greys_cast.jpeg" alt="cast photo"> | ||
<p class="main">We are #1 Grey's Anatomy fans!</p> | ||
|
||
</body> | ||
<footer> | ||
copyright Janice and Ericka 2023 | ||
</footer> | ||
</html> | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
.nav { | ||
color: darkslategrey; | ||
text-align: left; | ||
background-color: lightblue; | ||
display: inline-block; | ||
border-style: dotted; | ||
border-color: slateblue; | ||
border-width: medium; | ||
} | ||
|
||
h3 { | ||
color: peru; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
body { | ||
background-color: lightblue; | ||
} | ||
|
||
p { | ||
font-family: Arial, Helvetica, sans-serif; | ||
font-size: 20px; | ||
color: black | ||
} | ||
|
||
.nav { | ||
color: darkslategrey; | ||
text-align: left; | ||
background-color: lightblue; | ||
display: inline-block; | ||
border-style: dotted; | ||
border-color:lightseagreen; | ||
} | ||
|
||
img { | ||
width:150px; | ||
height: auto; | ||
} | ||
|
||
Comment on lines
+1
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Throughout the project, there seems to be inconsistent tab-spacing. It'd probably be good to conform to 2 or 4 spaces for tabs. |
||
.character { | ||
color: grey; | ||
} | ||
.image-container { | ||
display: grid; | ||
grid-template-columns: repeat (4, 1fr); | ||
grid-template-rows: repeat (2, 1fr); | ||
grid-column-gap: 16px; | ||
grid-row-gap: 16px; | ||
} | ||
|
||
.item1 { | ||
grid-column:1/2; | ||
grid-row: 1/2; | ||
} | ||
|
||
.item2 { | ||
grid-column: 2/3; | ||
} | ||
|
||
.item3 { | ||
grid-column: 3/4; | ||
} | ||
|
||
.item4 { | ||
grid-column: 4/5; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
.main { | ||
color: black; | ||
} | ||
|
||
img { | ||
width: 800px; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
* { | ||
background-color: lightblue; | ||
margin: 10px; | ||
} | ||
|
||
.nav { | ||
color: darkslategrey; | ||
text-align: left; | ||
background-color: lightblue; | ||
display: flex; | ||
display: inline-block; | ||
border-style: dotted; | ||
border-color: plum; | ||
} | ||
|
||
p { | ||
color: darkolivegreen; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For semantic HTML, I'd expect there to be
h2
used beforeh3
. If you need it to beh3
in order to have a better font size, you should useh2
still and use CSS to change the text size.This goes throughout your project