Zoisite - L. Pollard #120
Zoisite - L. Pollard #120
Conversation
| app.register_blueprint(task_bp) | ||
|
|
||
| from .goal_routes import goal_bp | ||
| app.register_blueprint(goal_bp) | ||
|
|
||
| return app |
There was a problem hiding this comment.
I love what you have done organizationally in terms of separating out the goal_routes from the task_routes. One small tweak would be to make a new directory called "routes" to house those two files along with your helper.py.
Also, don't forget that if you do that, you will need an empty init.py file inside the routes directory. You also will need an empty init.py file inside your models directory!
| abort(make_response( | ||
| jsonify({"message": f"{cls.__name__} {model_id} not found"}), 404)) | ||
|
|
||
| return model |
There was a problem hiding this comment.
Great job making the validate model method class agnostic!
|
|
||
| } | ||
| if tasks: | ||
| goal_dict["tasks"]= [task.to_dict() for task in self.tasks] |
| request_body = request.get_json() | ||
|
|
||
| try: | ||
| request_body["title"] |
There was a problem hiding this comment.
I love the idea to include some error handling here. We unfortunately cannot simply try to see if the request body exists. Instead, lines 36-43 should be included in the try with line 32 removed!
| app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( | ||
| "SQLALCHEMY_TEST_DATABASE_URI") | ||
| "RENDER_DATABASE_URI") |
There was a problem hiding this comment.
Just something small to point out here. Lines 20 and 26 are currently the exact same which means that the line itself could be pulled out of the conditional entirely. This wasn't an issue before when you were differentiating between the testing and the development database, but now that it has all been updated to the Render database, we have that collision.
| if not model: | ||
| abort(make_response(jsonify({"message":f"{cls.__name__} {model_id} not found"}), 404)) | ||
|
|
||
| return model |
There was a problem hiding this comment.
Great job with this validate model method!
| request_body["title"] and request_body["description"] | ||
| except: | ||
| abort(make_response(jsonify({"details":"Invalid data"}), 400)) | ||
|
|
There was a problem hiding this comment.
Great attempt at error handling. Just a reminder however that lines 30-37 should be included in the try block here. The code on line 26 won't actually do anything besides returning true or false. A more appropriate approach might look like the following:
try:
new_task = Task.from_dict(request_body)
db.session.add(new_task)
db.session.commit()
return make_response(jsonify({"task": new_task.to_dict()}), 201)
| response_body = {"task":task.to_dict()} | ||
| db.session.commit() | ||
|
|
||
| return response_body |
There was a problem hiding this comment.
The put method could also use some error handling in case the necessary update attributes are not included in the request!
| # assertion 1 goes here | ||
| # assertion 2 goes here | ||
| assert response_body["message"] == "Goal 1 not found" | ||
| assert response.status_code == 404 |
| } | ||
| } | ||
| goal = Goal.query.get(1) | ||
| assert goal.title == "Build a habit of going outside daily" |
thanks for the extra time :)