Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poverty project #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Poverty project #2

wants to merge 17 commits into from

Conversation

jennaplusplus
Copy link

I have two programs in Ruby- one for outputting data (for Washington and South Dakota), and one that takes user input for counties in Washington. These are pretty basic, and I could do more with it, but I thought they were a decent baseline that I can start translating to Python. Glad to take any feedback before I start doing that.

@jennaplusplus
Copy link
Author

update: Python version of the data ouput program is committed.

@jennaplusplus
Copy link
Author

and the interactive one :)

@jennaplusplus jennaplusplus changed the title Poverty project in Ruby Poverty project in Ruby (and now in Python!) Apr 4, 2016
@@ -0,0 +1,47 @@
require 'pry'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nitpick but try to get in the hang of removing any remnants of your debugging process when you submit your PRs

@kariabancroft
Copy link

Updates look good!

@jennaplusplus
Copy link
Author

I just committed some java. So far, I've succeeded at outputting the first line of each of the text files. Wondering if you have any feedback as I continue.

private static final Map<String, String> stateFiles;
static
{
stateFiles = new HashMap<String, String>();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HashMap works here, might recommend using the Dictionary instead

@jennaplusplus jennaplusplus changed the title Poverty project in Ruby (and now in Python!) Poverty project Apr 7, 2016
@jennaplusplus
Copy link
Author

Updated with Java! I have two programs, corresponding to the two programs that I wrote in Ruby and Python.


public class GetPovertyInfo {

public static String getMatch(String county) throws FileNotFoundException {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you added the throws here. I would say it is more typical to put a try and catch around the block of code than to put the throws at the method level.

@kariabancroft
Copy link

.jar files should be excluded from your check ins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants