Hrw/master - wave 3 PR #47
Conversation
| @title = "New Album" | ||
| @action = "update" | ||
| @method = :patch | ||
| @model = Album.find(id) |
There was a problem hiding this comment.
Since you're not using the variable id from line 30 again anywhere else, you could pass the params directly into the find method.
@model = Album.find(params[:id])
|
Your code was super clean and easy to read. Also, fantastic commit messages. Kudos for polymorphic paths and using shared examples! I added a couple of suggestions for additional test cases, so you can keep in mind for next time. Please let me know if you need further clarification on anything! Great job 👍 |
| it "redirect_to :index" do | ||
| expect(subject).to redirect_to :index | ||
| end | ||
| end |
There was a problem hiding this comment.
For some additional testing, you could also check the model to see if if the count is equal to 1 after the medium is created. You could also create a set of params that are invalid and check to see if the count in the model is equal to 0.
l'm having trouble figuring out how to input my specific controller params into a shared rspec. It worked for some of my tests, but not for others. It seems the methods that call my strong params are the ones I'm having trouble with (create and update). This seems to be what's holding my testing coverage at 89%.
I'm going to focus on looking into this issue over the weekend and may submit another PR on Sunday if I'm able to find a solution. I plan on studying up on shared specs, and different types of tests I can write for controllers and models. I felt that being shaky on syntax was holding me back when I was trying to figure out how to write good tests.
Other than those problems with some parts of specs, I think I did ok catching up on the project. I've checked each view and my site looks pretty identical to the heroku site. I took pretty quickly to bootstrap and matching my divs to the example.