Kld/master - final PR #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| # Place all the behaviors and hooks related to the matching controller here. | |||
| # All this logic will automatically be available in application.js. | |||
| # You can use CoffeeScript in this file: http://coffeescript.org/ | |||
There was a problem hiding this comment.
Not required, but you could consider removing extraneous .coffee files that you are not using as a way to clean up your application directory.
|
Great work on this project @kdefliese ! It is clear that you understand key ruby concepts around CRUD actions and it is awesome that you are exploring new things with trying to implement single table inheritance. Some of my notes are small style-guide-type comments, which aren't critical but are good habits to build early on. Industry code reviewers will notice and appreciate the readability. Keep it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I set up individual models/controllers/views/tests, I decided to refactor and break everything. I used a tutorial on single table inheritance to set up a single model/controller/set of views for Medium. This went pretty well, but the paths got pretty complicated. I used some helper functions that were in the tutorial to construct paths, but I wasn't 100% sure how that was working/how to test everything, so it's a little bit wonky in places...
http://samurails.com/tutorial/single-table-inheritance-with-rails-4-part-1/ is the tutorial that I used.