forked from AdaGold/betsy
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seabay/master - finished the project! #13
Open
kdefliese
wants to merge
466
commits into
Ada-C4:seabay/master
Choose a base branch
from
dezshino:seabay/master
base: seabay/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,312
−23
Open
Changes from all commits
Commits
Show all changes
466 commits
Select commit
Hold shift + click to select a range
38362a9
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 1f5fe7d
Undid the migration to remove image columns on merchants
trowbrsa c46d2e2
creating form to edit orderitem status plus migration
hougland 2987f65
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 9f9be43
added formatting to order confirm page
kdefliese b051729
Added link for merchants to create new categories
trowbrsa 9da7184
added orderitems table to order confirm page
kdefliese 81a5f79
Updated category controller
trowbrsa 684e586
Merge branch 'kld/master' into seabay/master
kdefliese 41716c3
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 5834833
edit wording
dezshino 50636fd
form to edit shipping status on orderitem
hougland c7cd470
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 7d40543
format money
dezshino 36b2002
added more details to order confirm page
kdefliese 6b03700
Merge branch 'kld/master' into seabay/master
kdefliese 35e3751
Added additional tests to product_controller
trowbrsa af36d86
Styling
dezshino 228df2b
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 4f1b0d3
Merge pull request #33 from desireepoland/dfp/master
dezshino 075e5a9
add routes and links for viewing orders by status
hougland 4cf8205
Update wording
dezshino b09fda3
prevented orders when product has 0 stock
kdefliese 3fb4cf1
create views for orders based on status
hougland 19e4b6e
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland db89589
format currency
dezshino 3544051
display orderitem status on order fulfillment page
hougland 181b2af
add total revenue by status to order status pages
hougland e18d747
add total revenue by status to order status pages
hougland be4f639
center/offset merchant home page items
dezshino 47ed9f0
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino fa1d954
Added additional testing for product and sessions controller
trowbrsa 4e40ce7
format currency
dezshino 89d2e0a
view num of orders from order status pages
hougland 35db59e
show page for merchant to view individual order
hougland 068fd3d
added error and remove item from cart when you try to purchase out of…
kdefliese 3f82979
Merge branch 'kld/master' into seabay/master
kdefliese 2855012
updated products controller
trowbrsa 6d86094
Merge branch 'sarah/master' into seabay/master
trowbrsa 978e081
Merge branch 'seabay/master' of github.com:desireepoland/betsy into s…
trowbrsa a7c165a
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino b6b3bd4
fix reviews bug
hougland 78fa41a
style login page with bootstrap
hougland 3d60920
change price type to decimal
dezshino 87a6d91
update to reflect decimal values
dezshino bea3f76
fix bug so the index view of cart deletes products from the cart hash…
hougland 67986f4
remove binding.pry
hougland ac249f5
update form to indicate dollar input instead of cents
dezshino 66692d2
format currency
dezshino 0432ba6
Merge pull request #34 from desireepoland/dfp/master
dezshino 0bb2fec
add tests for add_quantity and index for carts controller
hougland 33ba7ad
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 9400b24
add remove_quantity test to carts controller specs
hougland f44b802
remove pending spec
dezshino 727a7e0
style flash errors
dezshino 8d53e69
add test for order items controller's edit method
hougland d010f5e
added to order specs
kdefliese 55014c8
Merge branch 'seabay/master' of github.com:desireepoland/betsy into k…
kdefliese d2e82c1
Added method for merchants to retire products
trowbrsa 5a1bece
Deleted unncessary cart:session method in session controller
trowbrsa 2ff123f
Fixed merge conflict in schema
trowbrsa 7166bf6
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino e3e30c7
orderitems controller test update action
hougland 5886c69
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 56f6aaf
got order spec to work for no inventory option
kdefliese a09ce8f
migration
hougland 88d1234
Merge branch 'seabay/master' of github.com:desireepoland/betsy into s…
kdefliese d8ec1ac
fixed erroneous puts statements in rspec
kdefliese 5bdb1de
Added method to reactive product on product show page
trowbrsa 2604a6a
Merge branch 'sarah/master' into seabay/master
trowbrsa 1aed16c
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 4b41d96
add link to root route in carts index view
hougland b78b792
create before action in orders controller to get order items
hougland 9401531
add more before actions to DRY orders controller
hougland 8a19fcc
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino c443cca
capitalize Retired status
dezshino 6a440f7
display no item message if all a merchants products are retired
dezshino 23af96a
Merge pull request #35 from desireepoland/dfp/master
dezshino ae45a4f
RSPEC tests for Product. Still not working
trowbrsa 22bdcaa
tests cover get_order_items method in orders controller
hougland fcb1486
added background image to login page
kdefliese 24c8a9f
added flash error styling to login page
kdefliese 4a2b4c2
added bgimage and styling to register page
kdefliese c3ae9d9
added flash error styling to register page
kdefliese f6fca70
tests for orders controller
hougland 6b4c5a6
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland d8c207c
added transparent fake modal divs to signin/register pages
kdefliese b3041fd
Merge branch 'kld/master' into seabay/master
kdefliese 0619a38
Style jumbotron header, update page titles to seabay
dezshino 887b4dd
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 2a65582
More working RSPEC tests
trowbrsa 9e81f55
Merge branch 'sarah/master' into seabay/master
trowbrsa c35d9d3
rspec tests for orders controller
hougland 82b0bdf
keep jumbotron text over image at smaller screen widths
dezshino 4ff43ac
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 3cce8e4
Merge pull request #36 from desireepoland/dfp/master
dezshino f5e5ffb
100 coverage on orders controller yay
hougland 6712d65
Merge branch 'ricky/master' into seabay/master
hougland 5973435
Draft review spec
trowbrsa dd1315f
Merge branch 'sarah/master' into seabay/master
trowbrsa c3f362f
Edited review spec
trowbrsa 7bf36a6
add flash message in case merchant tries to review a product they own
hougland 67bb283
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 91cf8f0
fix rspec test for products controller
hougland b7b74f1
add a starfish favicon
dezshino 16f15e3
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 63494c7
Merge pull request #37 from desireepoland/dfp/master
dezshino 35482ed
katherine's css
dezshino 1484db0
Merge pull request #38 from desireepoland/dfp/master
dezshino 9638365
add test to products controller
hougland 13360d4
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland ffbbcfc
100 percent covered in products controller
hougland 37ea007
remove binding.pry
hougland f276064
hide Description header if product has no desription
dezshino 66a3800
Add default message if no description
dezshino d299f1c
add tests to carts controller spec
hougland 149ac4b
add tests to categories controller spec
hougland db211ee
changed home page style a little
kdefliese e3c0f8b
Added a page to view all products
trowbrsa 1165a9b
adding tests to merchant controller specs
hougland de421f2
Format, make add to cart more explicit
dezshino d9cfd21
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland f3c415f
Merge branch 'sarah/master' into seabay/master
trowbrsa 0b88240
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 9895373
Merge pull request #39 from desireepoland/dfp/master
dezshino 6738fe6
added field for category jumbotron image
kdefliese dce8c4b
added jumbotron images to category show pages
kdefliese db710bf
jumbotron style adjusting
dezshino 026fd4e
add authorization to create new categories page
dezshino 682c558
bootstrap new category form
dezshino f9882e8
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino affb910
Merge pull request #40 from desireepoland/dfp/master
dezshino 5149daf
changed category page to display three products per row
kdefliese 51be02e
changed shop by merchant page to display three products per row
kdefliese b5c2746
Merge branch 'kld/master' into seabay/master
kdefliese 40bcefd
Style merchant home page with background image
dezshino 4b2461a
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 9ef6a8a
Merge pull request #41 from desireepoland/dfp/master
dezshino 2e33c92
Added 'view all products' link on nav bar and made retired products i…
trowbrsa f026986
add require login to view order show pages
dezshino 9edc7bb
rspec test in products controller still not fixed, but commented out
hougland 79e8e07
added style to cart page
kdefliese 7f98639
add has many through relationship
hougland cccf13e
Merge branch 'kld/master' into seabay/master
kdefliese fd86cf9
Added rspec test for Product.all method
trowbrsa 6bd2f89
Merge branch 'sarah/master' into seabay/master
trowbrsa 057bdc1
Merge branch 'seabay/master' of github.com:desireepoland/betsy into h…
hougland d82c4d9
erd
hougland c4bbd3b
failed investegation of failing rspec test
hougland e56d59a
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 03827ae
Merge branch 'seabay/master' of github.com:desireepoland/betsy into h…
hougland 0f809cb
added config for using paperclip on heroku
kdefliese 9223b4d
changed gemfile to sub in pg for sqlite3
kdefliese 23fe221
Fix currency value on orders index page
dezshino 725c7c6
images
dezshino dee479c
take out unneccasry .to_f
dezshino 6b8ba92
updating config file for papertrail
kdefliese 29606a9
changed aws gem version
kdefliese bf691b8
ran bundle install
kdefliese 1ccccc1
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino abe7d36
Merge pull request #42 from desireepoland/dfp/master
dezshino f5aaa59
fixed config for AWS
kdefliese a796d52
fix bug where merchant can see other merchant's products on a shared …
hougland c18587b
Merge branch 'seabay/master' of github.com:desireepoland/betsy into h…
hougland 39ca67d
trying to get paperclip to work on heroku
kdefliese 24bb71e
updated production config file for paperclip
kdefliese 34d9dcb
Display a message on product show page if no reviews
dezshino 13f9ced
trying different version of aws gem
kdefliese 25bcb60
updated config files
kdefliese ae451f9
coverage at 100 percent
hougland 30dfbb6
added aws host name
kdefliese 98f2937
changed aws host_name to REST endpoint
kdefliese fc67634
merchant home url no longer shows merchant id
hougland 95aee37
changed config for aws
kdefliese ea42a22
default image size on product#show for seed photos
dezshino fc62f24
Merge branch 'kld/master' into seabay/master
kdefliese 98bd5bf
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino a13cf96
display reviews as a table
dezshino ab0ce81
Merge pull request #43 from desireepoland/dfp/master
dezshino e4492d8
display no review message in a table row
dezshino c12014d
change header size for consistency
dezshino 0082ba2
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 78efd4f
Link to merchants show page from product show page
dezshino ca0c4b1
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino cc27466
Merge pull request #44 from desireepoland/dfp/master
dezshino 26aa1b0
trimming unused carts routes'
hougland 9b63d51
fixed cart so it is set to nil if empty because products were sold out
kdefliese bb8dc92
drying up routes
hougland 18cf772
commented out all seeds
kdefliese 024259f
drying up routes
hougland f3c23de
rearranged merchant home route so it got it before merchants/:id routes
hougland 5bfc5b4
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland a9afec9
formatting in routes file
hougland 14ab09b
fix bug in order confirm page
hougland 488d77b
Each review has a starfish rating rather than a single number now
trowbrsa 49e133e
added home page image size to categories paperclip
kdefliese f0517df
referenced new paperclip size on home page view
kdefliese 82f0304
Added average review rating for each product
trowbrsa c73f5e8
Merge branch 'seabay/master' of github.com:desireepoland/betsy into s…
trowbrsa 3ef37f3
drying up orders controller code and fixing a bug
hougland 5708f6f
Updated order checkout page
trowbrsa 2a9fe74
Merge branch 'sarah/master' into seabay/master
trowbrsa d689297
changed size of home page images for categories
kdefliese ee9de66
Added method so that each item only appears once on checkout list
trowbrsa 9f0c2dc
updated spacing for category show page
kdefliese 6a67fd9
changed category images
kdefliese 643722d
Merge branch 'kld/master' into seabay/master
kdefliese 58a18ae
updated product photo urls on cat and merchant show pages
kdefliese d0a1d3c
cc_num length validaton
dezshino 5dcfbf6
fixed product images
kdefliese 9d134d9
actually really fixing this photo thing I think
kdefliese f020b12
code that should show forms errors but isn't quite yet
dezshino 8c8523b
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 11e8946
add model methods to start drying out revenue code
hougland da47532
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 71166e1
trying different home page styling
kdefliese e91d567
spacing changes on homepage
kdefliese 7601a50
the homepage is my style nemesis
kdefliese f9dc1c3
add class method to calculate cost of array of orderitems
hougland 3bdad64
Wrote rspec test for @average method
trowbrsa 5fb4196
Merge branch 'sarah/master' into seabay/master
trowbrsa d8d7af7
updated cart page
kdefliese a7262fe
Merge branch 'kld/master' into seabay/master
kdefliese 37b8d94
default image
dezshino 51b1f26
default size if photo_url
dezshino 8ace365
fixed bug in average rating function
kdefliese 3e2015b
dry up code
hougland 0ad2b26
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland b9037b7
dry orderitems controller with before action
hougland bd2974e
dry product controller with before action to find product
hougland 9c1a8d9
default product image if none given
dezshino 157c81f
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino a574903
Merge pull request #45 from desireepoland/dfp/master
dezshino 300a817
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland 1b876ad
fix to show default_image when appropriate
dezshino fa159dc
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 93f313f
Merge pull request #46 from desireepoland/dfp/master
dezshino c243da6
Merge branch 'seabay/master' of github.com:desireepoland/betsy into r…
hougland a7a3720
Standardize size on merchant show page
dezshino 18e9d29
fix broken test from changing routes
hougland e578d22
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 1cf5426
add test for order model method
hougland 7dce613
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino 0189921
take out capitalization
dezshino 494a8e1
Merge pull request #47 from desireepoland/dfp/master
dezshino fd2bba3
fix retired products showing up on category show page
dezshino 9a30cc3
Merge branch 'seabay/master' of github.com:desireepoland/betsy into d…
dezshino c5e40b9
Merge pull request #48 from desireepoland/dfp/master
dezshino a06bb1f
comment out length validation for now
dezshino 2dfa124
Merge pull request #49 from desireepoland/dfp/master
dezshino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--color | ||
--require spec_helper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Place all the behaviors and hooks related to the matching controller here. | ||
# All this logic will automatically be available in application.js. | ||
# You can use CoffeeScript in this file: http://coffeescript.org/ |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rails generated files are super cool- but if you have a bunch you don't use, best practice would be to delete the empty files (though soon you will have full javascript files too! :) )