Snailwhale: PR 1 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| session[:user_id] = @user.id | ||
| else | ||
| flash[:notice] = "Failed to save the user" | ||
| end |
There was a problem hiding this comment.
Do you need to write this as a nested if-block, or is there a different way to do this?
|
@jbuechs, @CShekta, @desireepoland, and @lgranger: Great job on this! Overall, this was a well-thought-out execution, and you did a very good job. Our feedback was mostly minor things like styling inconsistencies, and making sure you add all of the appropriate things to your .gitignore. If you have any questions, feel free to reach out to any of us. We'll be happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team trello board:
https://trello.com/b/sVeeJeV6/seemore