forked from AdaGold/2048
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2048! #11
Open
digivava
wants to merge
17
commits into
Ada-C5:master
Choose a base branch
from
digivava:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2048! #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll on the board, gave this.board = new Board() to Game
…ll if the cell is currently taken
… functionality is isolated in its own prototypal method
…oots of Charles help here, honestly.
…iles on top of other tiles
…lector was incomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it is!
So, I uploaded a separate branch with my original attempt, so you can see how I first tried to solve the problem. I had tried creating an entirely separate Board class, and using the "cell" divs to figure out which spots were already taken.
BUT! When I asked Charles for some help with a bug, he said that my way would get really complicated really soon, and then suggested a different way to do it. So I went with that instead, which is what you'll see on the Master branch. But because I struggled to understand his solution idea at first, I ended up having to spend more time asking him for help and working alongside him than I'd have liked to. (I mean Charles is awesome, but I wanted to feel like I was coming up with solutions more independently.)
Soooo even though I don't feel like this is "my solution" enough, I crammed my brain with a lot of new concepts that I'd never even considered, but look like they'll be useful in the future, and I worked hard to understand them.
One of the best parts was when we ran into several weird bugs with Charles' solution and I had to pair-program with him for a long time to figure it out. And for once, I felt like I was able to contribute good ideas about why things weren't working, and it was the first time I felt that I was capable of "keeping up" with his debugging. And we eventually figured things out together.
So YAY PROGRESS AS A PROGRAMMER. And yay Charles. He is amazing.