Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val & Suze's baseline + seeding of database #10

Open
wants to merge 54 commits into
base: master
Choose a base branch
from

Conversation

digivava
Copy link

https://trello.com/b/O70Umvs6/farmarrails

Here's the trello board, and then the ERD is inside app/assets/images.

Thanks!

SuzHarrison and others added 30 commits April 26, 2016 15:17
…en we migrate it will generate those columns
…ck Add A Product to go to a view for new products. will have form soon.
…s to create, edit vendor info in Vendor controller. Still need to add delete.
@SuzHarrison
Copy link

https://valsuzefarmar.herokuapp.com/

great project - Val and I worked well together--learned a lot from each other. Also learned to open new terminal windows, rails server...

spent a lot of time trying to understand results on sales index but then realized the products and sales don't all match in db.

have a good weekend! Thanks! Suze

def create
@market = Market.new(market_create_params[:market])
if(@market.save)
redirect_to market_path(@market.id)#redirect in case user tries to post another form - brings them to entered view
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great error handling here! Love the inline comments

@CShekta
Copy link

CShekta commented May 3, 2016

Great project! Your site is beautiful & functional & rad. Relationships are also super important to learn, and from this it is clear you got 'em down.
One note - rails-erd will create a relationship diagram for you if you want to use that! It will be a pdf if I remember correctly. But honestly I really liked image <3
Great commit messages as well. So impressed!

@annaleeherrera
Copy link

Good job committing frequently - it's definitely good practice to commit when you reach a good milestone, which you did a great job doing! Especially liked the meaningful commit messages.
Overall, great project! Your page has great functionality. The methods in your controllers are simple and not overcomplicated. Less is more!
It's also great you are making ERD's and thinking of relationships w tables- it was a huge concept for me to grasp.
Also, partials were a b**** for me to learn, so good job getting a grasp on that as well.
Excellent work! Killin it!

@SuzHarrison
Copy link

Annalee, thanks so much for taking the time to review our project! Your input is so important to us! 💙

Sent from my iPhone

On May 3, 2016, at 2:56 PM, Annalee Herrera [email protected] wrote:

Good job committing frequently - it's definitely good practice to commit when you reach a good milestone, which you did a great job doing! Especially liked the meaningful commit messages.

Overall, great project! Your page has great functionality. The methods in your controllers are simple and not overcomplicated. Less is more!

It's also great you are making ERD's and thinking of relationships w tables- it was a huge concept for me to grasp.
Also, partials were a b**** for me to learn, so good job getting a grasp on that as well.
Excellent work! Killin it!


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants