Baseline - PR with trello board and ERD picture #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince it was provided in csv.
…arket name, address, and a list of all vendors, which links to the individual vendor pages
…sh. It works now... can create new market action
…o prepare to make edit page
…ctions and when Rails uses them
…of having a visible field for market id input
|
Paired with Sarah N for this project. |
| def vendor_edit_params | ||
| params.permit(vendor: [:name, :no_employees]) | ||
| end | ||
| end |
There was a problem hiding this comment.
You can make one private params method and use it for all your controller actions! No need to separate between create and edit.
|
Great work! Very thoughtful clean code overall. |
| <% end %> | ||
| </ul> | ||
| <% end %> | ||
|
|
There was a problem hiding this comment.
Good error message to complement your model validations!
|
Great job, your code looks really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERD :
Trello : https://trello.com/b/xSjZw2a3