Setup Rails #4
Open
Setup Rails #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying our first merge
|
Heroku link = https://farmarrails.herokuapp.com/ |
| .columns { | ||
| width: 50%; | ||
| float: left; | ||
| margin-top: 20px; |
There was a problem hiding this comment.
Take a look at the settings in whichever text editor you are using to make sure tabs are set to 2 spaces. This won't be true for all languages but is generic for RoR.
|
Really nice job here! Great commit messages. When navigating your website I noticed that a few things could be added for better user experience:
Lastly, amazing usage of semantic HTML. You definitely don't have divitis! 💕 your code reviewers, Daphne & @knaydee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERD Photo http://imgur.com/EJRSKVd
Trello https://trello.com/b/zyLHVCIM/farmarrails
Heroku link = https://farmarrails.herokuapp.com/