Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anna and Adriana submission #7

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Conversation

annamm77
Copy link

@annamm77 annamm77 commented Apr 26, 2016

Adriana & Anna FarMarRails project!

Heroku Link: http://farmar-lookup.herokuapp.com/

farmarrails

https://trello.com/b/JykAcImM/farmarrails

annamm77 and others added 30 commits April 26, 2016 15:25
…resources for all that I need, still need to take out what won't be in use. Put a message on the index page to make sure things are connected correctly. touched index.html.erb files for markets and vendors as well as index pages for each of them
Merged active record
@annamm77 annamm77 changed the title trello and erb diagram Anna and Adriana submission Apr 30, 2016
height: 15rem;
float: left;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between vendor-card and vend-card might not be something you'd remember six months from now. Perhaps a slightly more descriptive term would work better.

@rileslovesyall
Copy link

Great job, ladies. You're Railsing!! Just make sure to keep an eye on that indentation and keeping things consistent. If you have questions about any specific comments, feel free to comment back. (I think Github will message me about comments, but you can also comment me in them.) Happy coding :)

def update
@product = Product.find(params[:id])
@product.update(product_update_params[:product])

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove random white space. This is nit-picky but I think in internships your teams will care about this so it's good to break the habit now. I see it in a few other places, but Riley also commented something similar, so you get the idea. 🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants