Jillian & Cristal's FarMarRails - First Pull Request #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tags and we're good?
…ed database. We're currently discussing if we would like to override the primary key to the id already contained within the csv files.
Merge branch 'master' of github.com:JBoshart/FarMarRails
… vendor are now completed.
|
Please make sure you make your Trello board public. |
|
Make sure you are only adding and commiting files that are necessary to the project. There are a few empty files committed which is not a huge deal but is something you may want to avoid in a workplace situation. 😄 |
|
Commit messages are funny, but in the real world they should be more meaningful. This post gives some good tips on the why of commit messages: |
| background-color: red; | ||
| }*/ | ||
|
|
||
| a{ |
There was a problem hiding this comment.
Try to maintain consistent styling throughout the code for readibility. There should be a space in between the selector and the curly bracket and there should be an empty line in between each CSS styling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is our trello board. Our ERD is contained within. https://trello.com/b/pAWK3yjy/far-mar-car