Baseline

[jlikesplants]

https://trello.com/b/I2rRvlyN/farmarrails

Experimented with online ERD generator- not totally sure about the connections it auto-generated. But it did help.

[emgord]

What if the zipcode starts with 0? Zipcode should be stored as a string, because as an integer if there is a zero at as the first character it will be dropped.

[emgord]

Really nice job on this project! You did a great job getting organized with your ERD diagram and making frequent and clear commits to track your progress. Your controllers are clear and you did a great job implementing basic CRUD methods and creating relationships between all your models. Try to keep all the logic in your models and controllers and avoid processing data in your views, and watch your instance vs. local variables in the controllers. Great job using partials as well!

[Dreedle]

omg I love lobster. watch your indents in this file, though.

[Dreedle]

I love the cabbages, and the look of the site, so much. (PS this is Audrey)

[Dreedle]

I can't figure out what @Market and @Vendor are used for in the index view. Maybe I'm just missing it- double check that you actually need this.

[jlikesplants]

Yeah- I think we put those there after developing another view that needed
them, realized we didn't for that one, and didn't take them back out.

On Tue, May 3, 2016 at 8:07 PM, Dreedle [email protected] wrote:

In app/controllers/markets_controller.rb
#9 (comment):

• def create
• @Market = Market.new(market_edit_params[:market])
• if @market.save

•  redirect_to markets_path
  

• else

•  render :new
  

• end
• end

• def index
• @markets = Market.all
• @Market = Market.first
• @Vendor = Vendor.first
• end

I can't figure out what @Market https://github.com/market and @Vendor
https://github.com/vendor are used for in the view. Maybe I'm just
missing it- double check that you actually need this.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Ada-C5/FarMarRails/pull/9/files/da2a02f087c82df712f5ab599b65813a6ffd05d7#r61986318

[jlikesplants]

Aw, thanks!!! I love cabbages and lobster too :)

On Tue, May 3, 2016 at 7:58 PM, Dreedle [email protected] wrote:

I love the cabbages, and the look of the site, so much. (PS this is Audrey)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9 (comment)

[jlikesplants]

Thanks so much for all your thoughtful and helpful comments! We definitely
debated where various pieces of logic should go, so that feedback feels
especially useful. And I definitely have a note somewhere to clarify where
to use instance vs local variables in this context, so thank you for that
as well. We appreciate your time!
<3
Justine

On Tue, May 3, 2016 at 4:07 PM, Emily Gordon [email protected]
wrote:

Really nice job on this project! You did a great job getting organized
with your ERD diagram and making frequent and clear commits to track your
progress. Your controllers are clear and you did a great job implementing
basic CRUD methods and creating relationships between all your models. Try
to keep all the logic in your models and controllers and avoid processing
data in your views, and watch your instance vs. local variables in the
controllers. Great job using partials as well!

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9 (comment)

[Dreedle]

Instead of doing things with 'format' in the params, you could use the relationship you set up between vendor and market and do @vendor.market when you need to refer to it's market. Seems simpler and then the route won't have a weird number after it in the url bar. Same goes for the other places you use 'format'.