TaskListRails #11
TaskListRails #11
Conversation
…nders based on completion status;
This reverts commit b0ba44b.
…nd update tasks db;
…completed tasks count;
…re wouldn't work;
…ecting blank option;
| @@ -0,0 +1,28 @@ | |||
| == README | |||
|
|
|||
There was a problem hiding this comment.
It's always useful to change this README to something that describes your project. (I'm sure this wasn't a requirement for this project, but it's something I wish someone had mentioned to me earlier on.) Check out some other projects to get a sense of what might go here. Makes everything look more profesh.
There was a problem hiding this comment.
I will check out some examples, thanks for the tip!
|
Great job on your first Rails project!! Definitely saw some new syntax that I didn't even know was possible-- so that's rad. Good use of clear commit messages, clear code, good separation of concerns. A random thing you might find useful: Rails use .scss files instead of just .css. This is "Sass," which means you can define variables at the top of the file and then use those throughout. (Among other cool sass things, but I never got too far into it.) I found this very useful when changing around styles. Here's a link, if that's something you're interested in exploring: http://sass-lang.com/guide |
|
@rileyrileyrose Thanks for the review! I will definitely look into sass for future projects. |
Sophia Baldonado
http://sophia-tasklist.herokuapp.com
Fun project, rails is so intense and awesome and scary. I liked having to figure out all of the stuff that allowed me to use very few views and very little unique html, for example how I used the _task partial anywhere I show a task, whether it's the task#index, task#show, or person#tasks. It made changing things really easy because they would change everywhere I needed them to. I could have spent more time on CSS but oh well.