-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yordanos Dirar - Task List #13
base: master
Are you sure you want to change the base?
Conversation
redirect_to root_path | ||
end | ||
|
||
def save_edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does save_edit
do? Not immediately apparent.
Yordanos, this looks great! Amazing that you've been doing Rails for a week and able to do this! My only big feedback is that you should commit more often!!!! And write descriptive commit messages. I never built up this habit in Ada and now am kicking myself at my job. It's really important to commit when you make any change and describe what it is you did. I would say as a rule, if you ever find yourself typing Other than that, great style and great Rails app! Your logic at the controller level is sound and the CSS is awesome. If you have any questions about Rails/my comments please reach out to me. I'm always available. 👍 💯 Logan |
# # (app/controllers/admin/products_controller.rb) | ||
# resources :products | ||
# end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to remove all this extra commented out stuff Rails gives you, but you don't have to.
https://yd-task-list.herokuapp.com/
Please note, some links are not working. Sorry about the mess.
Yordanos