Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val's Task Tracker! #15

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Val's Task Tracker! #15

wants to merge 21 commits into from

Conversation

digivava
Copy link

Here ya go!

It definitely does not have as nice of a user experience as I would like, but alas, this is what I've got in time for the PR deadline. At least it works!

digivava added 21 commits April 19, 2016 14:25
…at I did. I'm about to start working on the Edit button.
… add page. Need to figure out how to make this update route work.
…cause it's the verb that determines what to do with a route too
…ng name attribute to DONE button, which allows the update method to use the right params depending on if it was the DONE button or edit button
…ask model, and made it so layout only shows DONE button if the task is still incomplete
<li><%= link_to "Edit", edit_task_path(task.id) %></li>
<li>
<%= link_to "Delete", task_path(task.id), method: :delete,
data: { confirm: 'Are you sure you want to delete this task?' } %>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of confirm to have user verify delete action! 🚀

@kedevlin
Copy link

Nice work! I love how consistent you are with indentations and spacing. It makes it really easy to read your code. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants