-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css #18
base: master
Are you sure you want to change the base?
css #18
Conversation
|
||
def delete | ||
|
||
@tasklist = RailsTaskList.find(params[:id]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You repeat this line in a few places, so you could possibly it out into a before_action
only for certain controller methods if you don't think that would reduce clarity.
Nice! What you have here is really well-thought-out. Some things to think about:
|
data: { confirm: 'Are you sure?' } %> | ||
<span> | ||
|
||
<span><%=link_to "Done!",done_task_list_path(task.id),method: :patch%></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn't appear to be working.
https://sarah-tasklist.herokuapp.com/