TasklistRails #20
TasklistRails #20
Conversation
… user has put in data in the data fields. - Added a flash error message in the task controller - Created an each loop and provided a conditional in order to prevent a nil for the .each
|
|
||
| def show | ||
| @person = Person.find(params[:id]) | ||
| end |
There was a problem hiding this comment.
Looking good! Watch some of the indentation-- although Ruby doesn't mind if alignment is off, it can get confusing when you have lots of methods and you're trying to find a missing end or something :)
|
@rishallen One nice thing about Heroku is that we can rename our applications if we misspelled something or just want to change the name: We won't be quite this lucky during capstones however... once we purchase a domain name we can't get a refund because it wasn't quite right. 😄 |
| <% if task.completion_status != "done" %> | ||
| <% uncompleted_tasks << task %> | ||
| <%= uncompleted_tasks.length %> | ||
| <% end %> |
There was a problem hiding this comment.
This is great that you're thinking about displaying just the uncompleted tasks-- it would probably be better to put this logic in the controller or model and have an instance variable that you can use in the view.
So I learned an important lesson, check your spelling!
I spelled my first web app wrong. So a heads up its: risha-takslist.herokuapp.com
I spent more time on this project doing the things the set up vs the css. I did however try to do the concepts of what I wanted to do for css in a few areas.
i also meant to set up a validation for the people class and feel asleep.So will do that as well.