-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suz: TaskListRails #22
base: master
Are you sure you want to change the base?
Conversation
…d_at retains the info and checkbox remains checked unless you uncheck it.
…g to go to show page.
…here it should go? Works but not sure it's the best placement.
…add a task functionality working again.
…r that this wsa a class method for completed tasks count, duh.
gem 'web-console', '~> 2.0' | ||
# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring | ||
gem 'spring' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the better_errors
gem to be really helpful if you wanted to added that? I forget but it's either here or in development/test.
t.datetime "updated_at", null: false | ||
t.integer "person_id" | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yay first database!
Awesome job on this! I really like your approach to organizing the code in the model. Make sure your variable and method names are descriptive and convey to the reader what they do. Other than that, this is a GREAT first Rails project. Put your heroku link in the descriptions when you PR so I can see your awesome style on the internet! Logan |
Logan! thanks you so much for reviewing my code! Date: Wed, 27 Apr 2016 17:04:55 -0700 Awesome job on this! I really like your approach to organizing the code in the model. Make sure your variable and method names are descriptive and convey to the reader what they do. Other than that, this is a GREAT first Rails project. Put your heroku link in the descriptions when you PR so I can see your awesome style on the internet! If you have any questions, don't hesitate to contact me. Warm regards and congrats on a great project, Logan — |
styling is not as much as I had hoped due to time issues.
learned about merging parameters (a little confused still) and many things about check_box in form_for.
amazed by Rails "magic"