Task List Rails - on the real live internet! #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic for generating show task
…ime: time request submitted, completed time: time request submitted, complete: true)
…pretty and helpful
…nd i don't need to enter logic for updated_at - rails does it
…p down on new task and edit form
| display: flex; | ||
| flex-direction: column; | ||
| flex-wrap: wrap; | ||
| justify-content: center; |
There was a problem hiding this comment.
I didn't know you could justify content with CSS - cool!
|
First off, congratulations on your new baby!!! Reading this comments should be the LOWEST priority for you right now, you've got much more important things to think about! :) Overall, really really great work! Good commit messages, clean and clever methods, and helpful comments in the code that made it easy for me to understand what was happening and why you made certain decisions. I couldn't find anything I thought you should improve - you're doing great! Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nahmisa-tasklist.herokuapp.com
This is probably as good as it is going to get! I've got baby pushing class tonight and it ends at 8:30 so.... sorry it's still a little messy!