Adriana's TaskMaster Salty-Ocean #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r all pages in application.html.erb. Added in my data in index.html.erb and updated all the names so correct things were displayed
…elete,add but now to start the railsy way of doing it
…ectly. updated the controller to add in date completed time. made a radio button instead of a select box which destroyed all the things
…Made status always default to Not Started by doing a migration
…tatement so that when a date is completed, it puts it to the very bottom of the list.
…to tasks. Added associations. In partials, added a belongs to field. Restarted database and reseeded data
…as well as showing extra data for each person.
…e correct person at the time. formatted
|
|
||
| /*label.radio { | ||
| padding: 0 60px; | ||
| }*/ |
|
My #1 advice for PRs would be to do a quick check over your code before you submit, and pull out anything that is extraneous: commented out code, notes you made to yourself, code that isn't used anymore, etc. Great job with you first rails project! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All requirements were finished. I am happy that I got the date to work in a more functional manner. I was also able to make data that was completed go to the bottom of the page. I feel like I fought this assignment the whole way through, so not sure if I did any super fun things, I'm just happy that it's working the way I wanted it to as well as the styling looked the way that I wanted it to.