Ditzy Pull Request #2
Conversation
Pulling in Rowans changes
…e product id for linking the review.
…f hardcoded options.
Pulling in Jade and Rowan's new changes
…ouldn't have it now.
…r is logged in or not logged in.
| @@ -0,0 +1,3 @@ | |||
| class Order < ActiveRecord::Base | |||
| has_many :order_items | |||
| end | |||
There was a problem hiding this comment.
You may want to have more validations on order, like a credit information must be present, etc. Also any calculation logic can go in this model file.
|
I am really impressed! I love that there are a ton of commits, the website looks great, and all your associations are solid. Keep thinking about the fundamental difference between the M, V, and C in MVC and what should go in the model, views, or controller. Something that can really help you level up in thinking this way is understanding scopes and methods in the model. Congrats on finishing your first group project! |
| <strong>Product ID:</strong> <%= product.id %><br> | ||
| <%= link_to product.name, user_product_path(product.user_id, product.id) %><br> | ||
| <%= product.price %> | ||
| </p> |
There was a problem hiding this comment.
Some of this @product loop is repeated in other views and could be a partial.
|
Woooops, lol just realized I was still logged into someone else's account while I was reviewing, deleting those and re-doing from my account. Sorry, it wasn't a rando! |
| } | ||
|
|
||
| li { | ||
| color: #42bad3; /* ditzy bright blue */ |
There was a problem hiding this comment.
I like that you commented to explain the colors! Easy to see what each are for
|
Betsy is a huge project, good job!! I love that you had lots of commits and associations were set up well. I noticed on the heroku site there is an error when when trying to buy an item or view the cart, so that's something to look into, but overall it looks really great :) |
Project for Betsy.
Leah, Rowan, Jade and Sarah!
http://ditzy.herokuapp.com/products