Petsy #3
Petsy #3
Conversation
…Controller created and ready for routes
…rough controllers. need to work on animal vs category and getting 3 random costumes to show up instead of one
…ategories to show unique ones in the view
| <td><%= order.product.name %></td> | ||
| <td><%= order.quantity %></td> | ||
| <td>$<%= order.price %>0</td> | ||
| <td>$<%= order.price * order.quantity %>0</td> |
There was a problem hiding this comment.
Why is there a 0 here? Maybe check out some rails methods that convert pennies into dollars - I think you use these in other places in the project :)
|
WOO HOO!! YOU FINISHED BETSY!!! I hope some of my bazillion comments are actually useful for you. Feel free to comment back if you have any questions. Sorry if my comments are overwhelming. I intend them to be helpful and productive, not fussy and annoying. My biggest takeaways would be to 1) add comments to describe parts of your code that may not be obvious to a reader (like the routes and controller actions that aren't standard) and 2) separate out more logic from controllers and views and stick it in models. Your website is super pretty, and flows really well. I also luff the pet theme, images, and styling! 🐈 🐈 🐈 Awesome job! |
| belongs_to :product | ||
| belongs_to :user | ||
| validates :rating, presence: true, numericality: { only_integer: true, greater_than_or_equal_to: 1, less_than_or_equal_to: 5 } | ||
|
|
|
YOU SURVIVED BETSY!! I'm glad you are alive and well and didn't kill each other ;) I like that your code was simple and easy to read. There was not much excess. In the views, it could be cleaned up a bit with indentation, I know it gets a bit confusing when you are implementing ruby code. Try to keep any logic in the controllers vs. views. Good job committing frequently. But also beware of over-committing bc it could get messy when you want to track your process. You want to be able to clearly see what your process was, and have concise but descriptive commit messages. GREAT JOB TEAM!! KILLED IT. |
|
Thanks to all of you for your helpful comments! Going to keep these in mind going forward. We got put on the three-person team so we're just really proud to have completed the requirements given that it's a four-person project. We also had a lot fun finding pet costume pics. 🐈 😁 |
https://jd-petsy.herokuapp.com/
Project with Jess, Deirdre, and Alysia.
Gems in Gemfile.
Baked Potato Costume is amazing.