forked from AdaGold/js-scrabble
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrabble Eggs w/ JS #10
Open
BlueColorPencils
wants to merge
9
commits into
Ada-C5:master
Choose a base branch
from
BlueColorPencils:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the scrabble.js file to include the 2 fxn names for score and highest word.
… that returns the score. don't know if it works.
…eck the score function. it was previous broken because I missed brackets after called toUpperCase... the 2 tests pass.
…into account ties and deals with them. added tests to test the newly written fxn. all pass.
…r.js. Starting Wave 2 now.
…o take a name. tests pass
…ference each other. added tests for each of the fxns. all tests pass. onto highest score fxns.
…atement. added another test.
'Y':4, | ||
'Z':10 | ||
}; | ||
}; | ||
|
||
// YOUR CODE HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to remove unwanted comments before you submit PR
You did a great job! I enjoyed reading your code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wave 1 and 2 with tests. no optionals... twas fun