finished! #23
finished! #23
Conversation
|
|
||
| Player.prototype.hasWon = function() { | ||
| var total = Player.total_score; | ||
| if (total >= 100) { |
There was a problem hiding this comment.
you could consider a ternary operator here! :)
There was a problem hiding this comment.
just realized- you could one better than ternary here! you can just do: return (total >= 100);, which will be a boolean :D
|
Nice job! I found your comments super helpful as I made my way through the js functions. I think you can simplify some of your scoring code, but what you have works as it's supposed to. Good descriptive tests- just make sure they're testing what you think they are. |
|
💯 |
|
Thanks so much, Jenna! Those were very helpful comments and I appreciate On Mon, Jun 20, 2016 at 9:24 PM, Jenna Nichols [email protected]
|
Aaargh. I finished this at 3pm yesterday and forgot to turn it in. Sorry!