forked from AdaGold/js-scrabble
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrabble: JavaScript Edition #3
Open
jadevance
wants to merge
24
commits into
Ada-C5:master
Choose a base branch
from
jadevance:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o handle scoring each letter.
fixed a typo.
…ad and now it works
…e correct syntax for Jasmine Node
… the highest score from array of words
…the regex matching conditional
… into existence for wave 2
…ert and refute winning
… word from an array of played words.
… scoring word played
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My tests pass, but I still intensely like this: http://ghk.h-cdn.co/assets/cm/15/11/640x480/54ffe5266025c-dog1.jpg
I'm okay with the feeling though, which I think is progress.
Stuff I am proud of: I almost started duplicating code for scoring but realized I could use this.score in highest scoring word and BAM everything magically worked. I also wrote tests and then code for player and they worked which felt awesome. Even when they did not work I was able to trace back to where things were doing sideways which was also nice.