js-scrabble #7

Lisa-Sano · 2016-06-13T00:19:14Z

Lisa Rolczynski

…for that word

… insensitive

…h non-characters

…rom a list. if tied, returns the one with 7 letters, or the shortest, or the one earlier in the list (in that order)

… each test

…tarting to write tests

…them to the user in an array

…aining in the bag

…enough remaining is correct

loganmeetsworld · 2016-06-15T17:15:58Z

scrabble.js

 };

+Scrabble.prototype = {
+  helloWorld: function() {return 'hello world!';},
+


loganmeetsworld · 2016-06-15T19:34:17Z

Lisa, fantastic first fore into Javascript OOP. Your objects are clean, have single responsibilities, and the code is clear. There were a couple conditionals that may get kind of tricky but overall looked good. The only other thing I have is that I'd like to see more comments/documentation about what the purpose of different methods are. The methods here are pretty clear but it's custom to have docstrings at the start of methods in the real world so it may be good to start doing more of that. Other than that, beautiful tests and awesome code!

Lisa-Sano · 2016-06-16T02:15:53Z

Thanks so much @loganmeetsworld!

Lisa-Sano added 24 commits June 10, 2016 14:32

added a score method that accepts a word and returns the total score …

e01d67a

…for that word

wrote tests to check that the score method is functioning and is case…

c8d82d8

… insensitive

sevel letter words get a 50 point bonus

a59c07a

test to check that 7 letter words get a 50 point bonus

b71cf8f

score method returns a helpful statement if someone enters a word wit…

bdb0cb7

…h non-characters

added highestScoreFrom method that returns the highest scoring word f…

bf3778d

…rom a list. if tied, returns the one with 7 letters, or the shortest, or the one earlier in the list (in that order)

wrote tests for highestScoreFrom method

b2f3bc5

first commit

8c542f2

nested the tests within a 'Scrabble' describe block

eefa2b4

wrote tests for player.js

8dd00aa

added an afterEach block to reset the plays and scores to empty after…

0752f94

… each test

added play(word), total_score(), and hasWon() methods

a8672ed

fixed a typo that was calling the wrong method in a test

61690f8

added a highestScoringWord() and highestWordScore() method

ca34753

added more tests for edge cases

fe6e879

forgot a semicolon

916ac38

constructor for a tile_bag which fills the bag and shuffles it, and s…

36c4337

…tarting to write tests

removed a console.log that was used for testing purposes and forgotten

5d82956

added tests for the bag initialization and drawTiles() function

50f9ffa

drawTiles removes the given number of tiles from the bag and returns …

3821915

…them to the user in an array

changed the format of the tests to include a beforeEach

ba3f61e

returns a message if the person wants to draw more tiles than are rem…

a3d9372

…aining in the bag

wrote tests to check that the message returned from drawTiles if not …

665061d

…enough remaining is correct

refactored to exclude unnecessary true comparison

7892d60

Hamled assigned loganmeetsworld Jun 15, 2016

loganmeetsworld reviewed Jun 15, 2016
View reviewed changes

scrabble.js

};

Scrabble.prototype = {

helloWorld: function() {return 'hello world!';},

Copy link

loganmeetsworld Jun 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

js-scrabble #7

js-scrabble #7

Lisa-Sano commented Jun 13, 2016

loganmeetsworld Jun 15, 2016

loganmeetsworld commented Jun 15, 2016 •

edited

Loading

Lisa-Sano commented Jun 16, 2016

js-scrabble #7

Are you sure you want to change the base?

js-scrabble #7

Conversation

Lisa-Sano commented Jun 13, 2016

loganmeetsworld Jun 15, 2016

Choose a reason for hiding this comment

loganmeetsworld commented Jun 15, 2016 • edited Loading

Lisa-Sano commented Jun 16, 2016

loganmeetsworld commented Jun 15, 2016 •

edited

Loading