My tic-tac-toe! #11
Open
My tic-tac-toe! #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust for my own visibility, will change to something prettier later. Also gave data-position to each cell of table for referring to later.
…g if a player has won
…uldn't initialize, and made it so click handler connects to take_space method properly
…ck on an already-claimed square
…e to cat's game because that's what it's called in tic-tac-toe.
…ce that was already taken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had soooo much fun with this project! I did a lot of whiteboarding before writing any code, and worked hard to implement exactly the design I had in my head.
I also had fun thinking about ways to make the UX better (still a long way to go). And I found myself "thinking in callbacks" for the first time, which was exciting.
There's one major bug, which is that the turn doesn't switch after you choose a space that's already been claimed. (It still notifies you that you chose an already-taken space though.) I think I might have to significantly change the ways some of my functions work to fix that.