Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jillian's recursion homework #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 79 additions & 2 deletions recursion.rb
Original file line number Diff line number Diff line change
@@ -1,19 +1,96 @@
# RC: n! = n * (n-1)!
# BC: 1! = 1
# BC: 0! = 1

def fact(n)
if n == 0 || n == 1
return 1
end
return n * fact(n - 1)
end

# 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89
# example: fib(4) = 3
# BC: fib(1) = 1
# BC: fib(2) = 1
# exercises: fib(3) = fib(2) + fib(1)
# fib(4) = fib(3) + fib(2)

# fib(n) = fib(n-1) + fib(n-2)
def fib(n)
if n == 1 || n == 2
return 1
end
return fib(n-1) + fib(n-2)
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


def pal(s)
def binary(n)
#First param = number of digits we're expecting. Second param = binary being constructed. Third param = entire sequence of binary numbers
binary_helper(n,"","")
end

def binary(n)
def binary_helper(digits, binary, result)
if digits == 0
result += binary + " "
return result
end
result = binary_helper(digits-1, binary+"0", result)
result = binary_helper(digits-1, binary+"1", result)
return result
end

#BC - Any single character string is a palindrome.
#HOMEWORK
def pal(s)
array = s.split(//)
if array.length == 1 || array.length == 0
return true
elsif array[0] != array[-1]
return false
elsif array[0] == array[-1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could just be an else since it's the opposite case

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the note. Admittedly, I do tend to overuse elsif. I'll work on that.

array.shift
array.pop
s = array.join
pal(s)
end
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the readability of this solution -- though it does use auxillary storage (an array) which wouldn't have been needed if you applied the same logic to string slicing instead of converting to an array and then indexing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was initially headed down that road, but after a considerable amount of time failing the tests over and over, I changed course out of frustration and went with the way I was certain would work. But yes, I do agree, the auxillary storage is bulky. :-/


#BONUS HOMEWORK
def travel(x,y)

end

# Factorial Tests
raise "factorial broke - fact(4)" unless fact(4) == 24
raise "factorial broke - fact(0)" unless fact(0) == 1
puts "passes all factorial tests"

# Fibanocci Tests
raise "fib broke - fib(8)" unless fib(8) == 21
raise "fib broke - fib(20)" unless fib(20) == 6765
raise "fib broke - fib(1)" unless fib(1) == 1
raise "fib broke - fib(2)" unless fib(2) == 1
puts "passes all fibanocci tests"

# Binary Tests
raise "binary broke - binary(1)" unless binary(1) == "0 1 "
raise "binary broke - binary(2)" unless binary(2) == "00 01 10 11 "
raise "binary broke - binary(7)" unless binary(7) == "0000000 0000001 0000010 0000011 0000100 0000101 0000110 0000111 0001000 0001001 0001010 0001011 0001100 0001101 0001110 0001111 0010000 0010001 0010010 0010011 0010100 0010101 0010110 0010111 0011000 0011001 0011010 0011011 0011100 0011101 0011110 0011111 0100000 0100001 0100010 0100011 0100100 0100101 0100110 0100111 0101000 0101001 0101010 0101011 0101100 0101101 0101110 0101111 0110000 0110001 0110010 0110011 0110100 0110101 0110110 0110111 0111000 0111001 0111010 0111011 0111100 0111101 0111110 0111111 1000000 1000001 1000010 1000011 1000100 1000101 1000110 1000111 1001000 1001001 1001010 1001011 1001100 1001101 1001110 1001111 1010000 1010001 1010010 1010011 1010100 1010101 1010110 1010111 1011000 1011001 1011010 1011011 1011100 1011101 1011110 1011111 1100000 1100001 1100010 1100011 1100100 1100101 1100110 1100111 1101000 1101001 1101010 1101011 1101100 1101101 1101110 1101111 1110000 1110001 1110010 1110011 1110100 1110101 1110110 1110111 1111000 1111001 1111010 1111011 1111100 1111101 1111110 1111111 "
puts "passes all binary tests"

# Palindrome Tests
raise "pal broke - pal('racecar')" unless pal("racecar") == true
raise "pal broke - pal('helloworld')" unless pal("helloworld") == false
raise "pal broke - pal('')" unless pal("") == true
puts "passes all palindrome tests"

# Travel Tests
raise "travel broke - travel(1,2)" unless travel(1,2) == "ENN NEN NNE"
raise "travel broke - travel(2,2)" unless travel(2,2) == "EENN ENEN ENNE NEEN NENE NNEE"

puts "All test passed"


# Factorial Tests
raise "factorial broke - fact(4)" unless fact(4) == 24
raise "factorial broke - fact(0)" unless fact(0) == 1
Expand Down