Leah & Jillian's shipping service project #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get secrets for fedex and ups apis now
… we think we need to remove the colons on our post data
…duplicate the error.
| #Kept for testing purposes. | ||
| def index | ||
| render json: ["hello world"] | ||
| end |
There was a problem hiding this comment.
This was smart, to make up a route for testing! Just make sure that in a professional setting you take these out before you PR 🤓
| origin_params = params["origin_info"] | ||
| destination_params = params["destination_info"] | ||
| weight = params["package_info"]["weight"].to_i | ||
| dimensions = [params["package_info"]["height"].to_i, params["package_info"]["width"].to_i, params["package_info"]["length"].to_i] |
There was a problem hiding this comment.
Consider a private params method for getting these variables from your params.
|
Great job with your API! You made smart choices with your implementation and your organization was clean. 🎉💻🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/b/bfHHbI9m/shipping-betsy
https://betsyfour.herokuapp.com/
https://betsyshippingserviceapi.herokuapp.com/
Used UPS and USPS. Made some arbitrary choices about item weight and dimension so that we could focus on getting the API up and running.