shipping service api submission #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def destination | ||
| @destination ||= ActiveShipping::Location.new(country: 'US', |
There was a problem hiding this comment.
do @destination and @origin and @packages (below) need to be set as instance variables? Since they're not being used anywhere else, could they just be local variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deirdre & Anna
We are proud of how we handled the Order Item quantity in the packages method and that we were able to send back a specific error using ActiveShipping's error messages. It was great!!!!!
If we had more time, we could've added more tests.
betsy link: Lisa-Sano/betsy#1
heroku: http://shippingapi.herokuapp.com/