Ship It API; #8
Open
Ship It API; #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepared for receiving params
…s more descriptive;
| @@ -1,73 +1,24 @@ | |||
| *.gem | |||
There was a problem hiding this comment.
Audrey and Vans are commenting on this one
| @@ -0,0 +1,28 @@ | |||
| == README | |||
There was a problem hiding this comment.
Not a big deal, but it's generally a good idea to update the README :)
|
Great job on this project, especially with the test coverage! One more thing: some of the commit messages are a bit vague-- it will definitely help in the long run if the messages are a bit more specific :) |
| number_of_packages = (number_of_items / 4.0).ceil | ||
| packages = [] | ||
| number_of_packages.times do | ||
| packages << ActiveShipping::Package.new(7, [15, 10, 4.5], units: :imperial) |
There was a problem hiding this comment.
by not getting too caught up in details like package dimensions, you ended up with more time to implement tests and other cool stuff. nice project management!
|
@Dreedle @brittanykohler I know it's been a couple weeks, but thank you for reviewing this! I appreciate the reminders and tips. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ania Gonzalez & Sophia Baldonado
api site (nothing web facing): http://ship-it-api.herokuapp.com/
betsy site: http://ditzyplus.herokuapp.com/
betsy code: pottery123/betsy#2
This project was very interesting because we had a lot of conversations about what a real API would do in situations and who would have the responsibility for things, for instance, should the consumer be responsible for providing quality data? should we do some normalization and sanitation on the API end? Should we verify data formats before even trying to make a call to the shipping APIs? Lots of other good conversations. We are proud of the many validations we have. We created separate methods in the controller to handle data validations and status codes. We send different more specific statuses for different types of errors and we tried to give good responses so the consumer knows why their requests are failing or succeeding. We also got our tests to cover >95% of controllers and models which is awesome!