Mindy takeout and tunes #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite and unfavorite....I've been staring at it for 4 hours and I have no clue why @pairing isnt being passed from the link_to through the routes into the controller.....I'm getting 400 status code everytime and it seems not to know @pairing nor params[suggestion_id] once i make the post request to favorite and get routed into the controller method.....not really sure why
…ng problems with doing the same for the image
…cr and yml...have spent the past 2 1/2 hours researching and yeah...no clue yet...gonna keep going
…ly dont remember anything about css and wish i had more time to learn about it and work with it because its something that I feel i could be really good at, but yeah, it looks like complete crap now...
|
Hey @mcarson1111 ! Is this up on heroku? |
|
|
||
| CLIENT_ID: 84d3407e199f4c9bbbfe6e6e51b9fe0a | ||
|
|
||
| CLIENT_SECRET: 84c0798ce9b94370a384d263efccc892 |
There was a problem hiding this comment.
Oops. Don't want these exposed on github! I think you tried to gitignore them, but it didn't quite happen.
|
|
||
| class Restaurant | ||
|
|
||
| CLIENT = Yelp::Client.new({ consumer_key: ENV["YELP_CONSUMER_KEY"], |
There was a problem hiding this comment.
nice use of environment variables!
|
Phew! You've finished your most challenging project to date, and you can feel great about that! It's ok that you haven't mastered every element. You'll get there! I do recommend going back and cleaning up some of your unused code, it will help you with re-reading later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok....so...this is where I am with this. I am unhappy with where it is right now I'm turning it in and taking a break, for a bit on it, until I can figure a few things out.
I at least met MOST of the requirements except the testing.
I've been reading over everything on yml and vcr, and researching but I'm just not getting it.
I'm going to have my tutor teach me tomorrow so I actually understand what I'm doing with the testing and not just copy pasting just for the sake of getting it done.
Also, realizing that I haven't had much time to practice with styling and remember next to nothing about it now, and that makes me sad.
Also, I wasn't able to figure out how to implement a generic photo into the place of a music suggestion result if no photo is provided. I tried if the url is nil, but its not really nil, its just not getting the right info from spotify; the url's include this .open thing that doesn't result in an actual photo...can't figure it out.
I'm just unhappy with it, but my trello board is clear other than the testing, so I guess thats ok;
It just looks like junk and I feel like it took me WAY longer to implement each feature than it actually should have.
I also wish I would've remembered to commit more while I was going through each feature.
When I had to research or troubleshoot a lot and for long periods of time, I didn't want to commit messed up code :/ so I don't know. Here it is... hates it. Enjoy.
I'll do the testing tomorrow when its not just copy and pasting but ACTUAL understanding with my tutor.