All Features and Pages Complete - No Testing #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…takeoutwrapper functionality around favorites'
…music from pairing''
…nces of food/music
…d from, but not functional
|
Hey there! I'm Ricky, I'll be doing your code review for this project :) |
| @@ -26,7 +27,7 @@ | |||
| /tmp/ | |||
|
|
|||
| # Used by dotenv library to load environment variables. | |||
| # .env | |||
| .env | |||
There was a problem hiding this comment.
good job not checking your secrets in to github!
|
Overall, great job! It seems like this was a really complicated project, especially dealing with gems vs. wrapper, and funky models. Woohoo APIs!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished all the features and functionality, but of the few tests I wrote, virtually none work. I have no idea how to test, as it turns out.
Standardizing the output from all of the APIs, which somehow had almost no standardization and contained all kinds of junk, was the worst. BOO spotify, you're even worse than yelp.