Tunes&Takeout, Val edition! #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leaving that one alone.
…the matching suggestion resource
…accidentally put them in the user_test.rb but I moved them, hopefully they are in the right spot now.
…to get the images url correctly
… I add something to the index page
…ged-in users and guests differently, and added flash message to tell the user when they failed to login
… so trying now to decipher it and figure out why it's not working
…od. The greeting box at the top of every screen now accurately reflects if you are logged in or not.
…rs can see their spotify avatar in the greeting box
… big string of digits
…the requirement for that before whoops
…estions array to retrieve a random suggestion, instead of always the first one in the list
…ted their position
…s that suggestion to Faved when the index loads again. But user favorites page now broken.
…le confused by what all was going on there but oh well.
…ers, and made the UI ever so slightly nicer
…ringing you the login service
|
|
||
| def new | ||
|
|
||
| end |
There was a problem hiding this comment.
Empty controller methods like this can be re-written in one line like: def new; end
|
Great job on this project! APIs are a huge new concept - even if you weren't able to get the test coverage as high as you wanted, I think it's good you prioritized applying the new information. I don't see a heroku link for this, but I think I heard that wasn't required so it's all good. It's really great the amount you could do with this new topic in a short time frame! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here you go!
I wish I had had some time to style it more and play with UI/UX but.... this'll do!
I feel like I learned A LOT in this project. And there were a lot of challenges but they were all the kinds of things I feel like I'll run into on the job. So I feel like I leveled up in my docs-searching/stack-trace-reading/Google-fu a bit. Yay!
Test coverage still isn't what it could be, sadly. Sorry about that.. that's the one requirement that I didn't quite get done.