Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submission #7

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

submission #7

wants to merge 64 commits into from

Conversation

annamm77
Copy link

all requirements complete except for testing!

i need more exposure to using vcr/minitest/rails testing in general as it turns out.

annamm77 added 30 commits May 16, 2016 15:59
@annamm77
installed api gems for yelp and spotify. created models for user, foo…
5363b9f 
…d and music
@annamm77
burned down all the models
e22d07b
@annamm77
music model in progress, still need to filter by music type
9668baf
@annamm77
session and suggestions controllers created. added notes for spotifyi…
7cea6a4 
…tem model
@annamm77
TunesTakeoutWrapper created, might be working
88c9b13
@annamm77
TunesTakeoutWrapper returns instance of suggestion with readable attr…
6e1691c 
…ibutes
@annamm77
root path view displays
6836c3d
@annamm77
trying to get the tunestakeout wrapper to display on suggestions#inde…
9019e34 
…x. in an error state at the moment
@annamm77
search term will produce music item on index yaaaay
41a9dbf
@annamm77
can access yelp client with secret keys
a3268ae
@annamm77
it seems to display the food and music item when searched
cc410d1
@annamm77
added better_errors and fixed spotify music_id bug
1e155ea
@annamm77
added gems
ad552f9
@annamm77
views now link with application layout
4331e9c
@annamm77
general CSS and _suggestion partial styling
15f11d2
@annamm77
battling with spotifyitem @imageurl if no images are present... not s…
5defe44 
…ure if top 20 works yet, need to do this first
@annamm77
top 20 displays omg yus
53429c1
@annamm77
top 20 and seach functional, bug with artist and album pics persists
b06081a
@annamm77
minor formatting on suggestions#index, spacing
2a93ca3
@annamm77
log in link goes to correct page and path. sessions controller and vi…
6881533 
…ews set up
@annamm77
added omniauth initilizer, need to link keys
625adea
@annamm77
gems installed
d1758f2
@annamm77
added .env secret keys to omniauth initalizer
532a810
@annamm77
log in with spotify takes you to spotify auth page
30c94ee
@annamm77
you can log in? maybe. still need to check callback
c8399e3
@annamm77
index displays user name when logged in. Need to figure out how to lo…
98e2c4b 
…g out
@annamm77
you can log in and out using spotify omggg
4864998
@annamm77
added json gem, working on wrapper favorite post request
d39d24b
@annamm77
favorite will pick up user_id and suggestion_id
44c884d
@annamm77
favoriting feature works, will redirect to index with error message i…
9d0676b 
…n sessions
annamm77 added 29 commits May 20, 2016 14:01
@annamm77
will display user's favorites... yay yay yay
56ecb5d
@annamm77
added unfavorite link and path
3721d47
@annamm77
moved error message to applicaiton layout
774dc48
@annamm77
unfavorting redirects to favorites index
225062a
@annamm77
search and top 20 nav link for users
79250ae
@annamm77
guest cannot favorite or use search bar
493bc8b
@annamm77
username now links to spotify profile
a979d40
@annamm77
user now has img column and stores img data from oauth
bc3ba7b
@annamm77
spotify profile pic shows up
3c69017
@annamm77
greeting tweak
4a764d2
@annamm77
error message when search doesnt produce results
86a8f25
@annamm77
guest view displays greeting and default logo
7de8c08
@annamm77
user favorites are now stored in session[:favorites]
8ffbb8e
@annamm77
shows unfavorite or favorite link depending on users current favorite…
53dc338 
…s in suggestion partial
@annamm77
moved sessions[:favorites] declaration from session initlizer to appl…
2c39e95 
…ication controller.... much struggle was had. favorites and unfavorites bug is now fixed, it was calling the id instead of the username.
@annamm77
user model validation for spotify provider
8bcfcb8
@annamm77
images for artist and album now work, placeholder img for missing imgs
1613f22
@annamm77
added font awesome
f6476e2
@annamm77
CSS styling
de3ab83
@annamm77
css styling suggestio partial background
7113f61
@annamm77
installed testing gems
6a25819
@annamm77
simplecov is working
96e777d
@annamm77
gems for vcr
781c6d4
@annamm77
updated test_helper, trying to configure vcr
59a1c9f
@annamm77
more gems. all the gems. for testing
29b4b08
@annamm77
added omniauth to test_helper
9de18f3
@annamm77
added known_user fixture
67fb9a5
@annamm77
burned down test_helper and rebuilt anew
c0a899a
@annamm77
not sure what is up with vcr and my wrapper tests.. it doesn't seem t…
0d74d4a 
…o be creating the vcrs needed... more investigation needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@loganmeetsworld loganmeetsworld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annamm77 @loganmeetsworld