Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dianne Laguerta--FarMar #46

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Dianne Laguerta--FarMar #46

wants to merge 45 commits into from

Conversation

dlaguerta
Copy link

Finished primary requirements for FarMar, currently refactoring with better tests and methods.
Things I'm still learning:

  • What makes a good test/assertion?
  • To practice Enumerables, I find myself using .select often--are there other Enumerables that could be more appropriate in those instances?
  • FarMar looked daunting at first, but it's cool to actually finish in a week! wooooahhh

@dlaguerta
set up the structure for FarMar project
dbf0a9f
@dlaguerta
added gitignore
e3f4abd
@dlaguerta
deleting coverage
14f39a8
@dlaguerta
removed coverage hopefully
ab5a579
@dlaguerta
deleted require_relative comments, added and passed test for self.all…
b6daa18 
… method in Markets
@dlaguerta
added test for self.find method, passed test. yay.
73fae9c
@dlaguerta
added comments to remember to do the vendor method in Markets class
4434cd0
@dlaguerta
updating master with changes to Vendor, product spec, and vendor spec
e6b62e3
@dlaguerta
added spec for Vendor.all, added self.all method, make spec pass
951980c
@dlaguerta
added vendor spec test, writing the vendor self.find(id) method now
d303cad
@dlaguerta
wrote and passed self.find(id) method for Vendor
8bfc64a
@dlaguerta
added spec and method for initializing Product instances, passed
bb7c204
@dlaguerta
added spec for product self.all, created method, passed test
5ffeb12
@dlaguerta
fixed error with vendor id, verified that a vendor id is stored in hash
c7b793b
@dlaguerta
fixed error in spec for self.find
f9ed21d
@dlaguerta
fixed errors in self.find methods for both clasess
16d70ce
@dlaguerta
fixed market error, added spec for product's self.find method
724445b
@dlaguerta
added initialize method and spec for Sale class
77a174f
@dlaguerta
added self.all method for sale class, passed test
200123f
@dlaguerta
added self.find method for sale class, passed test
68fb5cf
@dlaguerta
added require CSV to top to for running in irb
9bd4d45
@dlaguerta
added edits
bc75dd4
@dlaguerta
I broke everything. Now I have to change all self.all and initialize …
b130202 
…methods. pray for me.
@dlaguerta
fixed errors so all specs pass at this point, edits self.find method …
3452f98 
…in Vendor class
@dlaguerta
fixed product hashes, fixed, specs, fixed methods yay
74a2bb7
@dlaguerta
fixed sales methods and specs
a765554
@dlaguerta
added markets method in Vendor class, passed spec
e67c0e7
@dlaguerta
added spec and method for by_market in Vendor class, cleaned up code
2f76e8a
@dlaguerta
added product methods and spec
3dddaba
@dlaguerta
added revenue method and spec, works great i think
31a17e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dlaguerta