Code

Allison Hoke#47

Code

Open

allisonhoke wants to merge 42 commits intoAda-C6:masterAda-C6/FarMar:masterfrom allisonhoke:masterallisonhoke/FarMar:masterCopy head branch name to clipboard

+831

Commits

Commits on Sep 6, 2016

• Completed baseline requirements. Need to do better at committing to git more often.

  allisonhoke

  committed
  98b51d4

• created self.find methods for all classes

  allisonhoke

  committed
  cc6b878

• created tests for self.find methods for each class. all tests passed.

  allisonhoke

  committed
  9c83981

Commits on Sep 7, 2016

• added new methods up to Vendor #products adn tests. all tests passing. 100% covered.

  allisonhoke

  committed
  9d032a8

• deleted a space

  allisonhoke

  committed
  c851394

• added vendor_id to attr_reader

  allisonhoke

  committed
  7a83814

• added vendor_id to attr_reader

  allisonhoke

  committed
  2255bf9

• added products and sales methods

  allisonhoke

  committed
  199c4c7

• created tests for products and sales methods. all tests pass

  allisonhoke

  committed
  1eb7aa1

• created a revenue method

  allisonhoke

  committed
  d6c2d2c

• created test for revenue method. WIP, write a better test

  allisonhoke

  committed
  aeba3e4

• changed #vendors method to call class method from Vendors class

  allisonhoke

  committed
  ae74db9

• adjusted test for vendors method due to addition of class method in Vendor that does the same job - new # of arguments

  allisonhoke

  committed
  2f9ed1a

• added self.by_market(market_id) method

  allisonhoke

  committed
  008feff

• finished test for revenue - all tests pass. created tests for self.by_market method. all tests pass

  allisonhoke

  committed
  c86c241

• wrote additional/more specific test for self.by_market method

  allisonhoke

  committed
  cfc5de5

• deleted unnecessary comments

  allisonhoke

  committed
  1937ef9

Commits on Sep 8, 2016

• wrote comment about idea to improve code

  allisonhoke

  committed
  a6add83

• created vendor method

  allisonhoke

  committed
  8a941bd

• created tests for vendor method. all tests pass.

  allisonhoke

  committed
  b2f3931

• added require 'time'

  allisonhoke

  committed
  704a6b9

• bad git message - cleaned up method code, used .find method

  allisonhoke

  committed
  8c9cb24

• bad commit message - cleans up method code. used .find method where applicable

  allisonhoke

  committed
  6794b23

• adjusted tests for cleaned up methods

  allisonhoke

  committed
  380d0c9

• adjusted tests for cleaned up methods

  allisonhoke

  committed
  65feaf2

• created vendor method

  allisonhoke

  committed
  ae0da7b

• created tests for vendor method. all tests pass

  allisonhoke

  committed
  2631802

• added product method and self.between method

  allisonhoke

  committed
  2726649

• created tests for product method and self.between method. all tests pass

  allisonhoke

  committed
  10ddc90

• used correct mthod calls on third test for self.between

  allisonhoke

  committed
  40445d6

• changed loop to enumerable in sales method

  allisonhoke

  committed
  7a61d56

• changed loop to enumerable in self.by_market method

  allisonhoke

  committed
  e637c3f

• changed loop to enumerable in sales method.

  allisonhoke

  committed
  9f069d7

• changed loop to enumerable in self.by_vendor method

  allisonhoke

  committed
  8360f59

• changed loop to enumerable in self.between method - is this a good idea? old code still there but commented

  allisonhoke

  committed
  da9fa1c

• adjusted test in vendors method to use before instead of let (this is unnecessary because the variable that is assigned is never mutated, but i wanted to try before

  allisonhoke

  committed
  ddf18cb

• clean up

  allisonhoke

  committed
  86ff37a

• confusion about what must be required

  allisonhoke

  committed
  69e45e8

• minor clean up

  allisonhoke

  committed
  427575f

• WIP trying to create ArgErr. code in comments needs to be figure out

  allisonhoke

  committed
  7606a7a

Commits on Sep 9, 2016

• added argument errors on methods that take in arguments.

  allisonhoke

  committed
  3e1ed98

• Commits got bad at the end. Changed .all methods in all classes to use class variables. Added the first optional enhancement #products in market class.

  allisonhoke

  committed
  f7004d6