forked from AdaGold/FarMarRails
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Karin Kubischta & Kate Shaffer #40
Open
wordkarin
wants to merge
59
commits into
Ada-C6:b/knk/master
Choose a base branch
from
wordkarin:master
base: b/knk/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dor page, 'Edit Vendor'.
…s with Edit/Delete buttons. Added confirmation to Delete Vendor & Delete Product links
…ess updated Sales controller
…ly a rough initial sketch.
Kate's styling draft branch
Kate Styling #2
…d destroy action for market
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our site is deployed to Heroku here: https://karkat-farmar.herokuapp.com/
We did not end up displaying different views based on user-type, although we chatted about several tactics we could have used and decided that given our time constraints we would make that a "refactor if we have time". We wanted to keep the routes as restful as possible, so in order to allow our customers to select to be a market or a vendor from the index page, we created a "site" controller, and several static pages for the portals.
We also chose to nest our vendors within our markets (a decision which we might have revisited after the fact), which meant that vendors only existed within the context of a market, and made some of our routes/controllers a little more complex than they may have needed to be. However, nesting products and sales within vendors definitely made sense.
We were able to divide up the work pretty well, allowing us to work in parallel for most of Wednesday and Thursday (awesome).
Known bugs: