Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karin Kubischta & Kate Shaffer #40

Open
wants to merge 59 commits into
base: b/knk/master
Choose a base branch
from

Conversation

wordkarin
Copy link

@wordkarin wordkarin commented Oct 7, 2016

Our site is deployed to Heroku here: https://karkat-farmar.herokuapp.com/

We did not end up displaying different views based on user-type, although we chatted about several tactics we could have used and decided that given our time constraints we would make that a "refactor if we have time". We wanted to keep the routes as restful as possible, so in order to allow our customers to select to be a market or a vendor from the index page, we created a "site" controller, and several static pages for the portals.

We also chose to nest our vendors within our markets (a decision which we might have revisited after the fact), which meant that vendors only existed within the context of a market, and made some of our routes/controllers a little more complex than they may have needed to be. However, nesting products and sales within vendors definitely made sense.

We were able to divide up the work pretty well, allowing us to work in parallel for most of Wednesday and Thursday (awesome).

Known bugs:

  1. It will break if you try to add a sale with no amount. We were working on validating that field but ran out of time.
  2. Sale amounts must also be entered as whole integer numbers (cannot enter in a $10.00 format, must enter as 1000).
  3. Current Month sales are the trailing month, rather than this month so far.

brookseakate and others added 30 commits October 4, 2016 14:39
brookseakate and others added 29 commits October 6, 2016 14:44
…s with Edit/Delete buttons. Added confirmation to Delete Vendor & Delete Product links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants