-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alyssa and Briana love Farmers Markets! #53
base: master
Are you sure you want to change the base?
Conversation
Controllers
Seeded vendors
Seeded sales and products
Added pages controller and created resource routes for all controllers
Adding model relationships
Methods start
…ted with the market index view to make sure the method was working
Regenerated the controllers since they were incorrectly named and tes…
Partial refactor of CSS
…s to work instead of going to singular pages (like market.1 instead of markets/1). Was because there was a route before markets called market so market was taking precedence. Just had to reorder them and now markets has precedence.
…pages and rendered it on correct pages
Final touches
What I worked on in the FarMarRails Project: I worked on the back-end stuff for the FarMarRails project (controllers/models, methods, some routes, different user paths, some structure of the views). What worked well in terms of teamwork: Alyssa and I pretty much split this project between front-end & back-end, which naturally gave a division of work. It made merging a lot easier since we typically didn't touch the same files/portions of the application. I feel like our styles/personalities worked well together since we're both pretty self-sufficient. Good discussion on the project as a whole, then just taking our pieces and running with it. What didn't go as well in terms of teamwork: We didn't actually talk as much since we divvied it up as front-end & back-end. Our core discussions were great though! The division of work also means neither of us got much experience in the other type of work. We also only had like two merge conflicts which kind of sucked since we wanted to practice mitigating those! Technical parts that went well and parts that didn't: For me, this helped getting the core methods and routine elements (forms, generating models/controllers) down a little better. I also had to figure out how to implement the Ransack gem which was little bit challenging but rewarding. Routes are feeling a bit better. Googling skills also feel well-used at this point. I feel like I got a couple "well we can't do this yet, but we can once we get into JS" answers when seeking solutions though, so I'm looking forward to that. |
@CheezItMan I primarily worked on the front-end aspects of our project. We didn't exactly intend to break up the work this way but after we made our big Trello to-do list, Briana started working on a few back-end tasks, and I picked-up some front-end tasks to work in parallel and stay out of her way. This worked out so well for us at the beginning that we just kept working this way. We brainstormed out project goals together, then Briana tackled a back-end aspect, and handed it off to me for UX and styling. We completed 25 merges and had just three merge conflicts as a result of this work flow (and our merge conflicts were all tiny--both of us trying to fix the same little error at the same time, for instance). Once we got rolling, we rarely had to talk to each other. As I ran into back-end issues (a search with no results would display nothing, for instance), I could put them on her portion of the Trello board and she'd tackle them when she had a minute. We came back together about once an hour to merge our code and talk about where we were and what we needed. I though our teamwork was completely on point, and really loved working with Briana. Working in parallel allowed us to very natural test our site. As soon as Briana finished one aspect and I styled it for her, we found ourselves using the site to navigate to other areas (rather than just typing in a URL to see a particular path). This allowed us to quickly troubleshoot UX issues, like forms that didn't redirect to what you might naturally want them to, search forms that returned no results, login pages that would fail if given non-numeric input, etc. There were definitely moments were Briana did back-end work that was technically correct based on our task board, but that felt wrong or lacking once we were actually interacting with those elements, and working in parallel front-end vs back-end made it really quick and easy to catch that. From a technical standpoint, I struggled with having multiple CSS documents, so all of my CSS is in one doc (600 lines long. Sorry!). I could use some help with image sizing so that the photos don't take so long to load. Everything else really went pretty smoothly. Briana crushed it with the Ransack gem and with the guest views versus logged in views (note that if you're a guest you can't edit, but if you're a market you can edit yourself or your vendors, if you're a vendor you can edit yourself or your products, and if you're an admin you can do it all). Overall, I really loved this project and had a great time working on it. Yay! |
@CheezItMan @PilgrimMemoirs
https://farmar-app.herokuapp.com/
Check out our trello board to see what we're still working on! We will likely PR again later this weekend.
This was a really fun project and I had a great time working with Briana :)