Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farmar Rails Submission for Quai Trish Sabrina (QTS) #56

Open
wants to merge 77 commits into
base: master
Choose a base branch
from

Conversation

Qlwentt
Copy link

@Qlwentt Qlwentt commented Oct 7, 2016

Trishthedish and others added 30 commits October 4, 2016 15:37
…weird tmp file pop up. I might need help deleting it or figuring out what to do with it.
fix purchase time to datetime and add market show page
readd functionality to see a market's vendors
Trishthedish and others added 27 commits October 6, 2016 15:21
…elete buttons in the show market page which also displays vendors.
SRW/Vendor create,edit and delete
add ability to create a sale associated with a product
…. So when market user attemps to delete something it asks them to confirm this choice.
include add sale in unordered list of buttons
Merge branch 'master' into qlw/vendor_view_month_sales
SRW/Added images, navigation, font.
@wilsab30
Copy link

Sabrina-

I worked mainly on vendors. Specifically-

  1. As a vendor, I can see a total of all of my Sales
  2. As a vendor, I can see a list of my Sales
  3. As a vendor, I can create, edit, or delete my Products

I also added the CSS to the site.

We did a great job of getting the app and trello setup as a team. We had some communication problems. We could have clarified what each item meant in trello, so there would be no confusion later. Writing the code for each task went while, but we had a major problem using Github to merge all of our work. In the end we had very clear steps as to where you did your work and how to push that work up to master.
@PilgrimMemoirs

@Qlwentt
Copy link
Author

Qlwentt commented Oct 11, 2016

@PilgrimMemoirs

I worked on the market new/create and edit/update pages as well as the market show page. For the vendors, I worked on creating a sale for a product and being able to see a list of sales for a particular month as well as the total.

As far as teamwork goes, I think my team did a really awesome job at communicating our needs upfront and working through issues together rather than letting things fester. One thing to improve was that we stepped on each other toes a bit and did work that overlapped with one another. This could have been avoided by more communication as to what specifically we were going to work on.

Technically, I thought our biggest challenge was merging in the beginning, but I think that was part of the growing pains of this being the first project where merging was a thing. Another technical issue was the fact that Heroku uses a different database than Rails does. This means that some of our code had to be changed once we pushed to Heroku and it didn't work. I think writing the code from the beginning knowing that it had to be compatible with postgres would have been beneficial for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants