Yasmin's API Muncher #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruby files in the lib folder
…p id and key, added .env file to gitignore and messed around in the edamam_api_wrapper file
…on a query parameter, created a search result class as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baseline requirements met.
I used a gem for pagination, but after talking with other classmates this weekend, I realized that we weren't meant to use the gem if we didn't know how to paginate without it. I don't know how to do that, but I plan to talk to someone this week who can walk me through it.
I don't know what memoization is, and I didn't realize that it was something we were meant to implement until Friday. Hopefully, it'll become clearer this week.
I chose to spend more time improving my use of semantic HTML, Foundation and general CSS styling than I have on past projects. The look and feel of my site is still pretty simplistic, but I'm glad I focused on playing around more with Foundation and CSS this project. Still, I think there is room for improvement in DRYing up the CSS.
Testing is sparse. My tests rely too much on the examples from class, and I'm having trouble going beyond that.