Alma #74
Open
Alma #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md Thx
… from console, some testing
…view at recipes#index set up with basic html and content. Working on pagation-search and list view.
…ch is using '/recipes' - and tests
… and to first page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the web styling in a separate branch as I discovered/created a bug with my pages buttons as I was working on HTML/CSS/Foundation stuff. Let me know if you want that branch and I'll create another PR for it. I don't want to merge it as one of my tests is failing (and it was not failing before the styling, but maybe the bug was there to hide it).
The pages work now (in the styling branch that I also pushed) but I had no one to ask over the weekend so my pagation solution is probably a little unusual. I made no save for the event that someone searches until the end of the search results, which I also wanted to do, but in the end I just wanted to figure out how to do the pages right (with the url adding '&page=3' at the top) and as I didn't I didn't have time to address it.
I also wanted to go back to the README to assert I did not miss any other requirements.
My trello board is here: https://trello.com/b/nWIyFWGK/api-muncher